Page MenuHomePhabricator

[keyserver] Update existing checks on isDefault in invite-link-creator.js
AbandonedPublic

Authored by atul on Nov 30 2023, 1:21 PM.
Tags
None
Referenced Files
F3522397: D10117.diff
Mon, Dec 23, 6:35 AM
Unknown Object (File)
Fri, Dec 20, 6:49 AM
Unknown Object (File)
Wed, Dec 18, 1:20 AM
Unknown Object (File)
Wed, Dec 18, 1:19 AM
Unknown Object (File)
Wed, Dec 18, 1:19 AM
Unknown Object (File)
Tue, Dec 3, 10:46 AM
Unknown Object (File)
Mon, Dec 2, 2:59 PM
Unknown Object (File)
Nov 14 2024, 10:48 PM
Subscribers

Details

Reviewers
ginsu
tomek
rohan
Summary

We now want to make sure that we get rid of checks on role.isDefault and replace them with checks on role.specialRole:

  • For default roles, this is `role.specialRole === ${specialRoles.DEFAULT_ROLE}
  • For admin roles, this is `role.specialRole === ${specialRoles.ADMIN_ROLE}

Part of ENG-5993

This diff handles invite-link-creator.js

Depends on D10116

Test Plan

Confirmed the use of roleIsDefaultRole had no change on the results in the code

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan held this revision as a draft.
rohan published this revision for review.Nov 30 2023, 1:34 PM
This revision is now accepted and ready to land.Dec 4 2023, 12:27 AM
atul edited reviewers, added: rohan; removed: atul.

No longer relevant since we have separate server and client types. In the future we will flip things when we have minimally encoded permissions in memberships table, at which point we can change the logic here.