Page MenuHomePhabricator

[keyserver][lib] handleAsyncPromise -> ignorePromiseRejections
ClosedPublic

Authored by ashoat on Dec 4 2023, 1:08 PM.
Tags
None
Referenced Files
F4089860: D10158.id34200.diff
Sun, Feb 16, 1:59 PM
Unknown Object (File)
Thu, Feb 13, 1:40 AM
Unknown Object (File)
Mon, Jan 27, 6:08 PM
Unknown Object (File)
Jan 17 2025, 9:55 AM
Unknown Object (File)
Jan 6 2025, 9:07 PM
Unknown Object (File)
Jan 6 2025, 9:07 PM
Unknown Object (File)
Jan 6 2025, 9:06 PM
Unknown Object (File)
Jan 6 2025, 9:04 PM
Subscribers

Details

Summary

As part of enabling the unused-promise Flow lint (ENG-5907), I want to make two changes to this function:

  1. Renaming it to ignorePromiseRejections. I think this captures what it does much better.
  2. Move it to lib. The Lint exposed some issues in lib utilities that we use from keyserver, and to fix those we'll want access to ignorePromiseRejections from lib.
Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage