Page MenuHomePhabricator

[lib] Don't return a promise from ignorePromiseRejections
ClosedPublic

Authored by ashoat on Dec 4 2023, 1:09 PM.
Tags
None
Referenced Files
F3365021: D10160.diff
Mon, Nov 25, 6:22 AM
Unknown Object (File)
Fri, Nov 22, 7:52 AM
Unknown Object (File)
Fri, Nov 22, 7:47 AM
Unknown Object (File)
Tue, Nov 19, 7:27 PM
Unknown Object (File)
Wed, Nov 13, 5:04 PM
Unknown Object (File)
Thu, Nov 7, 8:35 PM
Unknown Object (File)
Oct 16 2024, 10:31 PM
Unknown Object (File)
Oct 16 2024, 10:30 PM
Subscribers

Details

Summary

This diff is a no-op since no callsite actually pays attention to the result here.

The reason we need this is to avoid having to prefix every callsite with void. Otherwise, the unused-promise Flow lint that gets enabled in a following diff would fire at each callsite.

This diff avoids that by prefixing with void inside the definition of ignorePromiseRejections.

Depends on D10159

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage