[native] Add some awaits in ChatInputBar.onSend
ClosedPublic
Actions

Authored by ashoat on Dec 4 2023, 1:14 PM.

Details

Reviewers

michal
tomek

Commits

rCOMM4fa5ccfc5658: [native] Add some awaits in ChatInputBar.onSend

Summary

I could add voids here instead, but I figured it doesn't particularly matter, since this function (onSend) is passed to TouchableOpacity's onPress prop, which doesn't care whether a Promise is returned, or how long the Promise takes.

Depends on D10168

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 4 2023, 1:14 PM

ashoat added a child revision: D10170: [native] Don't make Crash.onPressWipe an async function.

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 4 2023, 1:40 PM

Harbormaster failed remote builds in B24748: Diff 34211!

Rebase

ashoat published this revision for review.Dec 4 2023, 6:27 PM

Harbormaster completed remote builds in B24765: Diff 34228.Dec 4 2023, 6:40 PM

michal accepted this revision.Dec 5 2023, 2:55 AM

This revision is now accepted and ready to land.Dec 5 2023, 2:55 AM

Closed by commit rCOMM4fa5ccfc5658: [native] Add some awaits in ChatInputBar.onSend (authored by ashoat). · Explain WhyDec 5 2023, 12:32 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM4fa5ccfc5658: [native] Add some awaits in ChatInputBar.onSend.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-input-bar.react.js

4 lines

Diff 34211

View Options

native/chat/chat-input-bar.react.js

[native] Add some awaits in ChatInputBar.onSendClosedPublicActions