[native] await sendMultimediaMessage in KeyboardInputHost.onMediaGalleryItemSelected
ClosedPublic
Actions

Authored by ashoat on Dec 4 2023, 1:15 PM.

Details

Reviewers

michal
tomek

Commits

rCOMM98251b6c47c6: [native] await sendMultimediaMessage in KeyboardInputHost.

Summary

We could add a void here instead, but onMediaGalleryItemSelected is already an async function, and the place we're passing it to doesn't await the result anyways. So might as well just add an await keyword.

Depends on D10170

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 4 2023, 1:15 PM

ashoat added a child revision: D10173: [native] Return inputState.sendMultimediaMessage Promise directly in ChatCameraModal.

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 4 2023, 1:43 PM

Harbormaster failed remote builds in B24750: Diff 34213!

Rebase

ashoat published this revision for review.Dec 4 2023, 6:27 PM

Harbormaster completed remote builds in B24767: Diff 34230.Dec 4 2023, 7:09 PM

michal accepted this revision.Dec 5 2023, 2:56 AM

This revision is now accepted and ready to land.Dec 5 2023, 2:56 AM

Closed by commit rCOMM98251b6c47c6: [native] await sendMultimediaMessage in KeyboardInputHost. (authored by ashoat). · Explain WhyDec 5 2023, 12:32 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM98251b6c47c6: [native] await sendMultimediaMessage in KeyboardInputHost..

Revision Contents
Changeset List

Path

Size

native/

keyboard/

keyboard-input-host.react.js

2 lines

Diff 34213

View Options

native/keyboard/keyboard-input-host.react.js

[native] await sendMultimediaMessage in KeyboardInputHost.onMediaGalleryItemSelectedClosedPublicActions