Page MenuHomePhabricator
Differential D10183

[keyserver] Ignore promise rejections from websocket message handler
ClosedPublic
Actions

Authored by ashoat on Dec 4 2023, 1:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 4:55 PM
Unknown Object (File)
Sat, Apr 19, 2:43 PM
Unknown Object (File)
Sat, Apr 19, 4:48 AM
Unknown Object (File)
Sat, Apr 19, 1:57 AM
Unknown Object (File)
Fri, Apr 18, 9:52 AM
Unknown Object (File)
Tue, Apr 15, 8:45 PM
Unknown Object (File)
Wed, Apr 9, 12:31 AM
Unknown Object (File)
Mon, Mar 31, 7:06 AM
View All 89 Files
Subscribers
tomek

Details

Reviewers
michal
Commits
rCOMM3f70a493979b: [keyserver] Ignore promise rejections from websocket message handler
Summary

The unused-promise Lint identified an issue here. onMessage can reject, in which case it doesn't appear to be handled.

To make sure it wasn't handled, I investigated how the redis library handles it. Internally that library extends Node's built-in EventEmitter, and that library explains how it handles things here. Since captureRejections: true is not set by the redis library, that means promise rejections will crash keyserver.

To avoid that, in this diff I wrap the call with ignorePromiseRejections. The conditional is necessary because onMessageCallback returns void | Promise<void>.

Depends on D10182

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
socket/
6 lines

Diff 34225

View Options

keyserver/src/socket/redis.js

Show First 20 Lines • Show All 306 Lines • ▼ Show 20 Lines class_<SQLiteQueryExecutor>("SQLiteQueryExecutor")
"addInboundP2PMessage", &SQLiteQueryExecutor::addInboundP2PMessage) "addInboundP2PMessage", &SQLiteQueryExecutor::addInboundP2PMessage)
.function( .function(
"getAllInboundP2PMessage", "getAllInboundP2PMessage",
&SQLiteQueryExecutor::getAllInboundP2PMessage) &SQLiteQueryExecutor::getAllInboundP2PMessage)
.function( .function(
"removeInboundP2PMessages", "removeInboundP2PMessages",
&SQLiteQueryExecutor::removeInboundP2PMessages) &SQLiteQueryExecutor::removeInboundP2PMessages)
.function( .function(
"getRelatedMessagesWeb", "getRelatedMessagesWeb", &SQLiteQueryExecutor::getRelatedMessagesWeb);
&SQLiteQueryExecutor::getRelatedMessagesWeb);
} }
} // namespace comm } // namespace comm
namespace emscripten { namespace emscripten {
namespace internal { namespace internal {
template <typename T, typename Allocator> template <typename T, typename Allocator>
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines