Paths
| Differential D10171 Authored by ashoat on Dec 4 2023, 1:15 PM.
Details Summary We could add a void here instead, but onMediaGalleryItemSelected is already an async function, and the place we're passing it to doesn't await the result anyways. So might as well just add an await keyword. Depends on D10170 Test Plan Flow
Diff Detail
Event Timelineashoat added a child revision: D10173: [native] Return inputState.sendMultimediaMessage Promise directly in ChatCameraModal. Harbormaster returned this revision to the author for changes because remote builds failed.Dec 4 2023, 1:43 PM2023-12-04 13:43:32 (UTC-8) Harbormaster completed remote builds in B24767: Diff 34230.Dec 4 2023, 7:09 PM2023-12-04 19:09:00 (UTC-8) This revision is now accepted and ready to land.Dec 5 2023, 2:56 AM2023-12-05 02:56:42 (UTC-8) Closed by commit rCOMM98251b6c47c6: [native] await sendMultimediaMessage in KeyboardInputHost. (authored by ashoat). · Explain WhyDec 5 2023, 12:32 PM2023-12-05 12:32:59 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 34230 native/keyboard/keyboard-input-host.react.js
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||