Page MenuHomePhabricator

[keyserver] await file operations for devs in MariaDB migrations
ClosedPublic

Authored by ashoat on Dec 4 2023, 1:19 PM.
Tags
None
Referenced Files
F3368103: D10180.id34314.diff
Mon, Nov 25, 6:10 PM
F3367907: D10180.id34238.diff
Mon, Nov 25, 5:05 PM
F3365897: D10180.diff
Mon, Nov 25, 8:19 AM
Unknown Object (File)
Fri, Nov 22, 8:56 AM
Unknown Object (File)
Thu, Nov 7, 5:09 AM
Unknown Object (File)
Sun, Oct 27, 1:52 PM
Unknown Object (File)
Oct 16 2024, 2:35 AM
Unknown Object (File)
Oct 16 2024, 2:35 AM
Subscribers

Details

Summary

We sometimes use MariaDB migrations to make updates to developers' environments.

The unused-promise Lint identified some cases where we don't await file operations. I think it makes sense to await these, so we can prevent the migration from continuing.

This could probably be optimized a bit, but I figure it doesn't really matter, since this code will probably never be executed again.

Depends on D10179

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable