Page MenuHomePhabricator
Differential D10362

[web] introduce account settings button for navigation sidebar
ClosedPublic
Actions

Authored by ginsu on Dec 15 2023, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 2:47 PM
Unknown Object (File)
Thu, Oct 31, 12:25 AM
Unknown Object (File)
Thu, Oct 31, 12:25 AM
Unknown Object (File)
Thu, Oct 31, 12:25 AM
Unknown Object (File)
Thu, Oct 31, 12:25 AM
Unknown Object (File)
Thu, Oct 31, 12:25 AM
Unknown Object (File)
Oct 3 2024, 11:09 AM
Unknown Object (File)
Sep 30 2024, 1:30 PM
View All 61 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM6607decfb50f: [web] introduce account settings button for navigation sidebar
Summary

This diff introduces the account settings button that will be rendered in the navigation sidebar footer

Linear task: https://linear.app/comm/issue/ENG-5930/community-sidebar

Depends on D10361

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 15 2023, 1:18 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 15 2023, 1:18 PM
ginsu edited the summary of this revision. (Show Details)Dec 15 2023, 1:22 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10361: [web] introduce navigation sidebar home button.
ginsu attached a referenced file: F954991: Screen Recording 2023-12-15 at 4.20.45 PM.mov. (Show Details)
ginsu added a child revision: D10363: [web] introduce community creation button for navigation sidebar.Dec 15 2023, 1:28 PM
Harbormaster completed remote builds in B25139: Diff 34749.Dec 15 2023, 1:59 PM
ginsu requested review of this revision.Dec 15 2023, 1:59 PM
rohan accepted this revision.Dec 18 2023, 1:59 PM
rohan added inline comments.
web/navigation-sidebar/account-settings-button.react.js
15–23
This revision is now accepted and ready to land.Dec 18 2023, 1:59 PM
ginsu updated this revision to Diff 34935.Dec 21 2023, 3:02 PM

address comments + rebase before landing

Harbormaster completed remote builds in B25298: Diff 34935.Dec 21 2023, 4:00 PM
Closed by commit rCOMM6607decfb50f: [web] introduce account settings button for navigation sidebar (authored by ginsu). · Explain WhyDec 21 2023, 4:41 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM6607decfb50f: [web] introduce account settings button for navigation sidebar.

Revision Contents
Changeset List

PathSize
web/
navigation-sidebar/
14 lines
41 lines

Diff 34749

View Options

web/navigation-sidebar/account-settings-button.css

Loading...
View Options

web/navigation-sidebar/account-settings-button.react.js

Loading...