Paths

Table of Contentst

Differential D10339

[identity] Switch Identity unit tests to autoscaling CI runners
ClosedPublic
Actions

Authored by atul on Dec 14 2023, 10:24 AM.

Tags

None

Referenced Files

	F3247919: D10339.id34648.diff
	Fri, Nov 15, 7:36 AM

	F3247903: D10339.id34863.diff
	Fri, Nov 15, 7:32 AM

	F3247895: D10339.id34647.diff
	Fri, Nov 15, 7:30 AM

	F3247534: D10339.diff
	Fri, Nov 15, 5:48 AM

	Unknown Object (File)
	Sun, Nov 3, 7:42 AM

	Unknown Object (File)
	Oct 12 2024, 7:29 PM

	Unknown Object (File)
	Oct 12 2024, 7:29 PM

	Unknown Object (File)
	Oct 12 2024, 7:29 PM

View All 82 Files

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek
rohan
bartek
varun

Commits

rCOMM9d4decdf1064: [identity] Switch Identity unit tests to autoscaling CI runners

Summary

Pretty much identical to D10328 but for Identity.

Context: https://linear.app/comm/issue/ENG-5770/office-mba-runner-out-of-storage#comment-d61c38e9

Test Plan

See if CI passes

40743c.png (2×2 px, 543 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

after updating herald rule

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 14 2023, 10:28 AM

Harbormaster failed remote builds in B25080: Diff 34647!

fix indent

atul mentioned this in D10340: [tunnelbroker] Switch Tunnelbroker unit tests to autoscaling CI runners.Dec 14 2023, 10:35 AM

atul published this revision for review.Dec 14 2023, 10:36 AM

atul edited the test plan for this revision. (Show Details)

atul mentioned this in D10341: [emscripten] Switch Emscripten CI job to autoscaling runners.Dec 14 2023, 10:44 AM

Harbormaster completed remote builds in B25079: Diff 34646.Dec 14 2023, 10:46 AM

Harbormaster failed remote builds in B25081: Diff 34648!Dec 14 2023, 11:11 AM

varun requested changes to this revision.Dec 14 2023, 12:13 PM

varun added inline comments.

.buildkite/identity_tests.yml
4 ↗	(On Diff #34648)	do we really need to install any of this?
5 ↗	(On Diff #34648)	i don't think we need protobuf to run unit tests

This revision now requires changes to proceed.Dec 14 2023, 12:13 PM

Harbormaster completed remote builds in B25081: Diff 34648.Dec 14 2023, 1:02 PM

varun added inline comments.Dec 14 2023, 10:17 PM

.buildkite/identity_tests.yml
5 ↗	(On Diff #34648)	we might need this actually... not entirely sure

bartek added inline comments.Dec 15 2023, 3:07 AM

.buildkite/identity_tests.yml
5 ↗	(On Diff #34648)	we might need this actually... not entirely sure Indeed https://phab.comm.dev/D10340#299698

atul mentioned this in rCOMM1a7b52ca376b: [tunnelbroker] Switch Tunnelbroker unit tests to autoscaling CI runners.Dec 19 2023, 12:15 AM

We need all the apt install and install_protobuf stuff

In D10339#301015, @atul wrote:

We need all the apt install and install_protobuf stuff

would you mind explaining why?

This revision is now accepted and ready to land.Dec 19 2023, 12:55 PM

without apt install

Harbormaster failed remote builds in B25234: Diff 34862!Dec 19 2023, 1:23 PM

back to working and land

In D10339#301021, @varun wrote:

In D10339#301015, @atul wrote:

We need all the apt install and install_protobuf stuff

would you mind explaining why?

Basically what @bartek explained in Tunnelbroker diff. Building requires prost which requires protoc. Here's what we get without:

f82a0c.png (898×2 px, 271 KB)

sorry, to clarify, i understand why we need protobuf. but i didn’t understand why we need all the apt install stuff. guessing they’re all dependencies of the install script?

In D10339#301040, @varun wrote:

sorry, to clarify, i understand why we need protobuf. but i didn’t understand why we need all the apt install stuff. guessing they’re all dependencies of the install script?

Yeah they're necessary for install_protobuf which is necessary because protoc from apt-get is ancient and I think we're preferring building from source instead of grabbing binary from GitHub releases?

got it, thanks for explaining!

This revision was landed with ongoing or failed builds.Dec 19 2023, 1:39 PM

Closed by commit rCOMM9d4decdf1064: [identity] Switch Identity unit tests to autoscaling CI runners (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM9d4decdf1064: [identity] Switch Identity unit tests to autoscaling CI runners.

Harbormaster completed remote builds in B25235: Diff 34863.Dec 19 2023, 2:01 PM

atul mentioned this in rCOMM1c776334d2ce: [emscripten] Switch Emscripten CI job to autoscaling runners.Dec 20 2023, 2:53 PM

Revision Contents
Changeset List

Path

Size

.buildkite/

blob_unittests.yml

2 lines

identity_tests.yml

14 lines

Diff 34864

.buildkite/blob_unittests.yml

Loading...

.buildkite/identity_tests.yml

Loading...