Page MenuHomePhabricator

[web] introduce community list item component
ClosedPublic

Authored by ginsu on Dec 15 2023, 12:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 1:30 PM
Unknown Object (File)
Wed, Dec 18, 9:23 PM
Unknown Object (File)
Nov 18 2024, 8:21 AM
Unknown Object (File)
Nov 18 2024, 8:19 AM
Unknown Object (File)
Nov 18 2024, 6:41 AM
Unknown Object (File)
Nov 17 2024, 11:16 PM
Unknown Object (File)
Oct 30 2024, 11:54 PM
Unknown Object (File)
Oct 30 2024, 11:54 PM
Subscribers

Details

Summary

This diff introduces the community list item component. This component will be used in a community list component that I will introduce in a future diff.

For context on what this should look like here is a screenshot from the figma:

Screenshot 2023-12-15 at 3.56.48 PM.png (876×106 px, 45 KB)

Part of https://linear.app/comm/issue/ENG-5947/list-of-all-top-level-communites-communities

Depends on D10358

Test Plan

Please see the screenshot below

Screenshot 2023-12-15 at 3.55.57 PM.png (1×178 px, 48 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu edited the summary of this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 15 2023, 1:37 PM
Harbormaster failed remote builds in B25136: Diff 34746!
ginsu requested review of this revision.Dec 15 2023, 1:39 PM

will make sure ci passes before landing

rohan added inline comments.
web/navigation-sidebar/community-list-item.react.js
28 ↗(On Diff #34746)

Just a question after seeing the screenshots in D10360 - could you share what the community list looks like if we use a medium ThreadAvatar?

This revision is now accepted and ready to land.Dec 15 2023, 4:33 PM
web/navigation-sidebar/community-list-item.react.js
28 ↗(On Diff #34746)

Here is what it looks like with medium thread avatars:

Screenshot 2023-12-15 at 8.50.30 PM.png (1×3 px, 836 KB)

I went with small because in the figma the dimensions for the thread avatar are 24x24 (which is the size of the small avatar)

Screenshot 2023-12-15 at 8.49.47 PM.png (586×588 px, 185 KB)

web/navigation-sidebar/community-list-item.react.js
28 ↗(On Diff #34746)

Ok got it, thank you for sharing the screenshots!