Page MenuHomePhabricator
Differential D10361

[web] introduce navigation sidebar home button
ClosedPublic
Actions

Authored by ginsu on Dec 15 2023, 1:09 PM.
Tags
None
Referenced Files
F3323326: D10361.id34934.diff
Wed, Nov 20, 3:33 AM
Unknown Object (File)
Mon, Nov 18, 3:41 AM
Unknown Object (File)
Tue, Nov 12, 10:53 PM
Unknown Object (File)
Sat, Nov 9, 2:33 AM
Unknown Object (File)
Wed, Oct 30, 11:54 PM
Unknown Object (File)
Wed, Oct 30, 11:54 PM
Unknown Object (File)
Wed, Oct 30, 11:54 PM
Unknown Object (File)
Wed, Oct 30, 11:54 PM
View All 58 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMMdd49d72028c0: [web] introduce navigation sidebar home button
Summary

This diff introduces the Home button for the navigation sidebar. In ENG-5949, @ashoat and I discussed changing the Inbox => Home to avoid ambiguity with the inbox app and improve the hierarchy between communities and apps

linear task: https://linear.app/comm/issue/ENG-5949/change-icon-of-all-communities-home-icon

Depends on D10360

Test Plan

Please see screenshot below

Screenshot 2023-12-15 at 4.09.34 PM.png (178×284 px, 8 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 15 2023, 1:09 PM
Herald added a subscriber: tomek. · View Herald TranscriptDec 15 2023, 1:09 PM
ginsu edited the summary of this revision. (Show Details)Dec 15 2023, 1:11 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10360: [web] introduce community list.
ginsu attached a referenced file: F954942: Screenshot 2023-12-15 at 4.09.34 PM.png. (Show Details)
ginsu added a child revision: D10362: [web] introduce account settings button for navigation sidebar.Dec 15 2023, 1:22 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 15 2023, 2:01 PM
Harbormaster failed remote builds in B25138: Diff 34748!
ginsu requested review of this revision.Dec 15 2023, 2:02 PM

will make sure ci passes before landing

atul accepted this revision.Dec 19 2023, 12:16 AM
This revision is now accepted and ready to land.Dec 19 2023, 12:16 AM
ginsu updated this revision to Diff 34934.Dec 21 2023, 2:53 PM

rebase before landing

Harbormaster completed remote builds in B25297: Diff 34934.Dec 21 2023, 3:52 PM
Closed by commit rCOMMdd49d72028c0: [web] introduce navigation sidebar home button (authored by ginsu). · Explain WhyDec 21 2023, 4:41 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMdd49d72028c0: [web] introduce navigation sidebar home button.

Revision Contents
Changeset List

Diff 34942

View Options

web/navigation-sidebar/navigation-sidebar-home-button.css

Loading...
View Options

web/navigation-sidebar/navigation-sidebar-home-button.react.js

Loading...