Page MenuHomePhabricator
Differential D10391

[web] show total unreads in the navigation sidebar home button
ClosedPublic
Actions

Authored by ginsu on Dec 18 2023, 2:15 PM.
Tags
None
Referenced Files
F3505275: D10391.diff
Fri, Dec 20, 12:58 PM
Unknown Object (File)
Thu, Dec 12, 12:17 AM
Unknown Object (File)
Sat, Nov 23, 12:27 PM
Unknown Object (File)
Oct 31 2024, 12:25 AM
Unknown Object (File)
Oct 31 2024, 12:25 AM
Unknown Object (File)
Oct 31 2024, 12:25 AM
Unknown Object (File)
Oct 31 2024, 12:25 AM
Unknown Object (File)
Oct 31 2024, 12:25 AM
View All 70 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM1c1d82c04824: [web] show total unreads in the navigation sidebar home button
Summary

This diff introduces the unread badge in the navigation sidebar home button component. Here we want to show the user the total number of unread messages they have on Comm across all of their communities

Linear task: https://linear.app/comm/issue/ENG-5951/introduce-a-new-unread-badge

Depends on D10390

Test Plan

Please see the screenshots below

Screenshot 2023-12-18 at 5.22.27 PM.png (436×522 px, 17 KB)

Screenshot 2023-12-18 at 5.22.47 PM.png (424×342 px, 16 KB)

Screenshot 2023-12-18 at 5.22.38 PM.png (352×312 px, 14 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 18 2023, 2:15 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 18 2023, 2:15 PM
ginsu updated this revision to Diff 34818.Dec 18 2023, 2:20 PM

update

web/navigation-sidebar/navigation-sidebar-home-button.css
21–22 ↗(On Diff #34818)

This is a bit of a strange case but I left a comment here, justifying why we need to do this

ginsu edited the summary of this revision. (Show Details)Dec 18 2023, 2:23 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10390: [web] introduce unread badge component.
ginsu attached a referenced file: F983158: Screenshot 2023-12-18 at 5.22.38 PM.png. (Show Details)
ginsu attached a referenced file: F983159: Screenshot 2023-12-18 at 5.22.47 PM.png. (Show Details)
ginsu attached a referenced file: F983160: Screenshot 2023-12-18 at 5.22.27 PM.png. (Show Details)
Harbormaster failed remote builds in B25199: Diff 34816!Dec 18 2023, 2:48 PM
Harbormaster completed remote builds in B25201: Diff 34818.Dec 18 2023, 2:51 PM
ginsu requested review of this revision.Dec 18 2023, 2:51 PM
ginsu added a child revision: D10393: [web] show unreads for each community in the community list.Dec 18 2023, 3:19 PM
ginsu updated this revision to Diff 34820.Dec 18 2023, 3:42 PM

update

web/navigation-sidebar/navigation-sidebar-home-button.css
23 ↗(On Diff #34820)

This is a bit of a strange case but I left a comment here, justifying why we need to do this

Harbormaster completed remote builds in B25203: Diff 34820.Dec 18 2023, 4:02 PM
rohan accepted this revision.Dec 19 2023, 6:54 AM
This revision is now accepted and ready to land.Dec 19 2023, 6:54 AM
ginsu updated this revision to Diff 34947.Dec 21 2023, 5:26 PM

rebase after addressing comments in D10393

Harbormaster completed remote builds in B25302: Diff 34947.Dec 21 2023, 5:48 PM
ginsu added a child revision: D10435: [lib] introduce unreadCountSelectorForCommunity.Dec 21 2023, 6:37 PM
ginsu removed a child revision: D10393: [web] show unreads for each community in the community list.
Closed by commit rCOMM1c1d82c04824: [web] show total unreads in the navigation sidebar home button (authored by ginsu). · Explain WhyDec 21 2023, 6:50 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM1c1d82c04824: [web] show total unreads in the navigation sidebar home button.

Revision Contents
Changeset List

Diff 34947

View Options

web/navigation-sidebar/navigation-sidebar-home-button.css

Loading...
View Options

web/navigation-sidebar/navigation-sidebar-home-button.react.js

Loading...