Page MenuHomePhabricator
Differential D10523

[web] update chat tabs to use the new tabs component
ClosedPublic
Actions

Authored by ginsu on Jan 4 2024, 1:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 3, 12:02 PM
Unknown Object (File)
Sat, Sep 14, 9:18 PM
Unknown Object (File)
Sat, Sep 14, 9:18 PM
Unknown Object (File)
Sat, Sep 14, 9:18 PM
Unknown Object (File)
Sat, Sep 14, 9:18 PM
Unknown Object (File)
Sat, Sep 14, 9:18 PM
Unknown Object (File)
Aug 27 2024, 12:37 PM
Unknown Object (File)
Aug 18 2024, 5:51 AM
View All 47 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMf5f5e19cb87e: [web] update chat tabs to use the new tabs component
Summary

This diff updates the chat tabs to use the new tab components. Since we decoupled the tabs from the tab content with this new tab component, the chat tabs now needs to be responsible for rendering the correct tab content.

Depends on D10522

Test Plan

Please see the demo video below to confirm that there are no regressions

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jan 4 2024, 1:35 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 4 2024, 1:36 AM
ginsu edited the summary of this revision. (Show Details)Jan 4 2024, 1:38 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D10522: [web] update thread settings modal to use the new tabs component.
ginsu mentioned this in D10524: [web] deprecate and clean up unused tabs code.Jan 4 2024, 1:43 AM
ginsu added a child revision: D10524: [web] deprecate and clean up unused tabs code.
Harbormaster completed remote builds in B25475: Diff 35189.Jan 4 2024, 1:54 AM
ginsu requested review of this revision.Jan 4 2024, 1:54 AM
atul accepted this revision.Jan 4 2024, 1:22 PM
atul added inline comments.
web/chat/chat-tabs.react.js
56–62 ↗(On Diff #35189)

Wouldn't hurt to memoize

This revision is now accepted and ready to land.Jan 4 2024, 1:22 PM
ginsu updated this revision to Diff 35309.Jan 5 2024, 12:55 PM

address comments + rebase before landing

Harbormaster completed remote builds in B25554: Diff 35309.Jan 5 2024, 1:12 PM
Closed by commit rCOMMf5f5e19cb87e: [web] update chat tabs to use the new tabs component (authored by ginsu). · Explain WhyJan 5 2024, 1:39 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMf5f5e19cb87e: [web] update chat tabs to use the new tabs component.

Revision Contents
Changeset List

Diff 35309

View Options

web/chat/chat-tabs.css

Loading...
View Options

web/chat/chat-tabs.react.js

Loading...
View Options

web/chat/chat-thread-tab.react.js

Loading...