Paths

Table of Contentst

Differential D10449

[native] Expose get keyserver keys Identity RPC
ClosedPublic
Actions

Authored by tomek on Dec 22 2023, 7:12 AM.

Tags

None

Referenced Files

	F2171089: D10449.diff
	Tue, Jul 2, 4:49 PM

	Unknown Object (File)
	Sat, Jun 29, 4:30 AM

	Unknown Object (File)
	Thu, Jun 27, 9:05 AM

	Unknown Object (File)
	Tue, Jun 25, 9:29 PM

	Unknown Object (File)
	Tue, Jun 25, 11:15 AM

	Unknown Object (File)
	Tue, Jun 25, 11:15 AM

	Unknown Object (File)
	Tue, Jun 25, 11:15 AM

	Unknown Object (File)
	Tue, Jun 25, 11:15 AM

View All 46 Files

Subscribers

Details

Reviewers

varun
bartek
michal
kamil

Commits

rCOMM90c438564d6d: [native] Expose get keyserver keys Identity RPC

Summary

Add Rust and C++ code that allows calling this function.

https://linear.app/comm/issue/ENG-6083/allow-calling-getkeyserverkeys-on-native

Depends on D10403

Test Plan

Call this function in a code introduced by D10327 and check if the keys are returned.

Diff Detail

Repository

Branch

handler-4

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Dec 22 2023, 7:12 AM

Herald added a subscriber: ashoat. · View Herald TranscriptDec 22 2023, 7:12 AM

tomek added a subscriber: kamil.Dec 22 2023, 7:18 AM

tomek added inline comments.

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp
284–286 ↗	(On Diff #34986)	This approach is consistent with other functions from this file, but I strongly suspect it is incorrect - as it ignores the error. The first function using this approach was introduced in https://phab.comm.dev/D8657 - @kamil is this the right approach?

tomek added a reviewer: kamil.Dec 22 2023, 7:18 AM

tomek removed a reviewer: inka.

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 22 2023, 7:26 AM

Harbormaster failed remote builds in B25324: Diff 34986!

tomek edited the summary of this revision. (Show Details)Dec 22 2023, 7:31 AM

tomek requested review of this revision.Dec 22 2023, 7:34 AM

varun mentioned this in D10374: [CommRustModule] implement `getInboundKeys`.Jan 2 2024, 9:02 AM

kamil added inline comments.Jan 3 2024, 12:25 AM

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp
284–286 ↗	(On Diff #34986)	In D8657 I only moved methods from `CommCoreModule` (D8654) without changing implementation or updating anything - but yes, probably you're right and methods were implemented incorrectly

kamil added inline comments.Jan 5 2024, 3:35 AM

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp
273 ↗	(On Diff #34986)	this also turned out to be incorrect, here is the proposed fix: D10550
284–286 ↗	(On Diff #34986)	I've added D10530 to fix entire file, would be nice if you could implement the same here

Fix error handling and capturing

Harbormaster failed remote builds in B25594: Diff 35363!Jan 8 2024, 6:00 AM

bartek accepted this revision.Jan 9 2024, 3:57 AM

This revision is now accepted and ready to land.Jan 9 2024, 3:57 AM

tomek added a child revision: D10584: [lib][native][web] Expose identity API by using a context.Jan 9 2024, 7:28 AM

Rebase

Format

Harbormaster completed remote builds in B25674: Diff 35498.Jan 10 2024, 7:57 AM

Harbormaster completed remote builds in B25675: Diff 35499.Jan 10 2024, 7:59 AM

Closed by commit rCOMM90c438564d6d: [native] Expose get keyserver keys Identity RPC (authored by tomek). · Explain WhyJan 11 2024, 6:47 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM90c438564d6d: [native] Expose get keyserver keys Identity RPC.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommRustModule.h

6 lines

CommRustModule.cpp

33 lines

_generated/

rustJSI-generated.cpp

native_rust_library/

src/

67 lines

schema/

CommRustModuleSchema.js

6 lines

Diff 35363

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Loading...

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/rustJSI.h

Loading...

native/native_rust_library/src/lib.rs

Loading...

native/schema/CommRustModuleSchema.js

Loading...