Page MenuHomePhabricator

[CommRustModule] improve params capturing
ClosedPublic

Authored by kamil on Jan 5 2024, 2:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 5:11 PM
Unknown Object (File)
Oct 18 2024, 1:24 AM
Unknown Object (File)
Oct 18 2024, 1:24 AM
Unknown Object (File)
Oct 18 2024, 1:24 AM
Unknown Object (File)
Oct 18 2024, 1:24 AM
Unknown Object (File)
Oct 15 2024, 3:19 AM
Unknown Object (File)
Sep 6 2024, 6:22 PM
Unknown Object (File)
Sep 6 2024, 6:22 PM
Subscribers

Details

Summary

Addresses https://phab.comm.dev/D10510#inline-64080.

Alternative is using std::shared_ptr, but I don't think is safe because as far as I know jsi::* objects lifetime is managed by the JavaScript runtime, is tied to the JavaScript garbage collector, not by C++ here itself, so I am afraid it could potentially lead to dangling pointers.

Depends on D10530

Test Plan

Test entire stack (it uses methods here).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable