Paths

Table of Contentst

Differential D10510

[CommRustModule] implement uploading one-time keys to Identity
ClosedPublic
Actions

Authored by kamil on Jan 3 2024, 7:21 AM.

Tags

None

Referenced Files

	F2151513: D10510.id.diff
	Sun, Jun 30, 12:51 PM

	F2147666: D10510.id35381.diff
	Sun, Jun 30, 2:39 AM

	Unknown Object (File)
	Sat, Jun 29, 1:36 PM

	Unknown Object (File)
	Thu, Jun 27, 10:57 AM

	Unknown Object (File)
	Sat, Jun 22, 8:19 PM

	Unknown Object (File)
	Sat, Jun 22, 3:12 PM

	Unknown Object (File)
	Sat, Jun 22, 10:51 AM

	Unknown Object (File)
	Sat, Jun 22, 10:51 AM

View All 33 Files

Subscribers

Details

Reviewers

marcin
varun
michal

Commits

rCOMM5771686dfa7a: [CommRustModule] implement uploading one-time keys to Identity

Summary

Upload keys using API

Depends on D10384

Test Plan

Login to device, check deviceID and open DDB of Identity on staging
Check number of one time keys
Call this method
Check DDb table if keys are there

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jan 3 2024, 7:21 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 3 2024, 7:21 AM

kamil added a child revision: D10511: [lib/shared] clean `RefreshKeyRequest` type.Jan 3 2024, 7:25 AM

Harbormaster completed remote builds in B25450: Diff 35158.Jan 3 2024, 7:40 AM

kamil published this revision for review.Jan 4 2024, 3:17 AM

marcin requested changes to this revision.Jan 4 2024, 4:00 AM

marcin added inline comments.

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp
297–302 ↗	(On Diff #35158)	The capture of lambda passed to `createPromiseAsJSIValue` should be by copy (`[=]`). You can't guarantee that those arguments will live until lambda completes. If you don't want to copy `jsi::Array` arguments (they might be big) then wrap them in `std::shared_ptr<>`.

This revision now requires changes to proceed.Jan 4 2024, 4:00 AM

marcin mentioned this in D10374: [CommRustModule] implement `getInboundKeys`.Jan 4 2024, 4:25 AM

rust code looks good

kamil mentioned this in D10550: [CommRustModule] improve params capturing.Jan 5 2024, 2:22 AM

kamil requested review of this revision.Jan 5 2024, 2:45 AM

kamil added inline comments.

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp
297–302 ↗	(On Diff #35158)	yeah, you're right, let's in this diff stick to the convention (even if it's wrong) and iterate on this in D10550

marcin accepted this revision.Jan 8 2024, 2:17 AM

marcin added inline comments.

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp
297–302 ↗	(On Diff #35158)	Usually we shouldn't create new diff to fix mistakes in another diff. But in this case you had to fix other methods implemented outside of this stack as well so we can proceed with this approach.

This revision is now accepted and ready to land.Jan 8 2024, 2:17 AM

rebase before landing

Harbormaster failed remote builds in B25604: Diff 35381!Jan 8 2024, 7:24 AM

This revision was landed with ongoing or failed builds.Jan 8 2024, 7:27 AM

Closed by commit rCOMM5771686dfa7a: [CommRustModule] implement uploading one-time keys to Identity (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM5771686dfa7a: [CommRustModule] implement uploading one-time keys to Identity.

kamil added a child revision: D10530: [CommRustModule] improve error handling.Jan 8 2024, 7:55 AM

kamil mentioned this in rCOMMe8b3f7e5a138: [CommRustModule] improve params capturing.Jan 8 2024, 9:17 AM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommRustModule.h

7 lines

CommRustModule.cpp

33 lines

_generated/

rustJSI-generated.cpp

native_rust_library/

src/

55 lines

schema/

CommRustModuleSchema.js

7 lines

Diff 35398

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Loading...

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/rustJSI.h

Loading...

native/native_rust_library/src/lib.rs

Loading...

native/schema/CommRustModuleSchema.js

Loading...