Page MenuHomePhabricator

[CommCoreModule] implement encrypting content with `olm` session
ClosedPublic

Authored by kamil on Dec 18 2023, 4:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 18, 1:09 AM
Unknown Object (File)
Fri, Oct 18, 1:09 AM
Unknown Object (File)
Fri, Oct 18, 1:09 AM
Unknown Object (File)
Fri, Oct 18, 1:09 AM
Unknown Object (File)
Fri, Oct 18, 1:09 AM
Unknown Object (File)
Fri, Oct 18, 1:08 AM
Unknown Object (File)
Sep 6 2024, 8:25 PM
Unknown Object (File)
Sep 6 2024, 8:25 PM
Subscribers

Details

Summary

Implemented method to encrypt content.

Depends on D10376

Test Plan

This code is really hard to test as it's impossible to verify partial results.
I generated some keys and values, verified them with olm-utils.test.js, and checked if they succeeded/failed when calling the method introduced here in the same cases as JS tests.
Full functionality tested later in the stack.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Dec 18 2023, 6:51 AM
marcin requested changes to this revision.Dec 21 2023, 3:23 AM
marcin added inline comments.
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
831 ↗(On Diff #34791)

This comment is relevant here as well.

This revision now requires changes to proceed.Dec 21 2023, 3:23 AM
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
823 ↗(On Diff #35143)

The term initialEncryptedMessage should be reserved for inbound session creation. Using it for an ordinary encrypted message is confusing to the reader. Please rename it to encryptedMessage before landing.

This revision is now accepted and ready to land.Jan 2 2024, 11:55 PM

initialEncryptedMessage -> encryptedMessage

This revision was landed with ongoing or failed builds.Jan 8 2024, 6:48 AM
This revision was automatically updated to reflect the committed changes.