Page MenuHomePhabricator

[native] add button to test send encrypted content between devices
ClosedPublic

Authored by kamil on Dec 18 2023, 6:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 12:51 AM
Unknown Object (File)
Fri, Nov 8, 7:06 AM
Unknown Object (File)
Thu, Nov 7, 7:32 PM
Unknown Object (File)
Oct 18 2024, 2:08 AM
Unknown Object (File)
Oct 18 2024, 2:08 AM
Unknown Object (File)
Oct 18 2024, 2:08 AM
Unknown Object (File)
Oct 18 2024, 2:08 AM
Unknown Object (File)
Oct 18 2024, 2:08 AM
Subscribers

Details

Summary

Sending encrypted messages to different devices.
As a follow-up, we can consider adding some alerts to make it easier to test on prod but still, at current state it could only be tested on the dev end.

Depends on D10382

Test Plan

This is the last diff on which I tested everything end-to-end

  1. Two devices on the same account
  2. Connected to staging Identity and Tunnelbroker
  3. Created a session (D10382)
  4. Verified that session is created on both devices
  5. Use this to send encrypted message to device (both ways)
  6. Look at logs and test if message is decrypted

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Dec 18 2023, 6:55 AM

@michal should have more context on react to give thorough review.

native/profile/tunnelbroker-menu.react.js
78 ↗(On Diff #34797)

Why are we using a dummy id here?

native/profile/tunnelbroker-menu.react.js
78 ↗(On Diff #34797)

I introduced SenderInfo (D10379) as deviceID and userID as I believe at some point those two will be needed.
Right now, we only need deviceID which is the key to getting olm session, and userID is not used in the current state.

Since in this component we don't have userID (Identity userID) used a dummy id as it was easier, it's only a test screen anyway. I can add a comment explaining or get userID from commCoreModule - what you think it's better.

native/profile/tunnelbroker-menu.react.js
78 ↗(On Diff #34797)

Identity userID should be the same as the normal userID. You can probably get this from Redux?

  • fix line width
  • use userID from Redux
native/profile/tunnelbroker-menu.react.js
78 ↗(On Diff #34797)

Identity userID should be the same as the normal userID. You can probably get this from Redux?

At the current state, while testing with staging those two are different - but since it doesn't make any change I can use it from Redux for clarity

This revision is now accepted and ready to land.Jan 9 2024, 2:56 AM