Differential D10369

[native] fix CommServicesAuthMetadata type
ClosedPublic
Actions

Authored by kamil on Dec 18 2023, 4:12 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 12, 3:32 AM

	Unknown Object (File)
	Tue, Feb 25, 5:54 PM

	Unknown Object (File)
	Feb 22 2025, 1:26 PM

	Unknown Object (File)
	Feb 22 2025, 1:26 PM

	Unknown Object (File)
	Feb 22 2025, 1:26 PM

	Unknown Object (File)
	Feb 22 2025, 1:25 PM

	Unknown Object (File)
	Feb 22 2025, 1:25 PM

	Unknown Object (File)
	Feb 19 2025, 6:25 PM

View All 78 Files

Subscribers

Details

Reviewers

Commits

rCOMM258c7e40fe08: [native] fix CommServicesAuthMetadata type

Summary

Looking at this line you can se that the field has a different name.

Depends on D10368

Test Plan

Call this method and check if the returned object aligns with the defined type.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Dec 18 2023, 4:12 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 18 2023, 4:12 AM

kamil added a child revision: D10327: [IGNORE] login device in Identity Service.Dec 18 2023, 4:15 AM

Harbormaster failed remote builds in B25166: Diff 34781!Dec 18 2023, 4:45 AM

kamil published this revision for review.Dec 18 2023, 6:46 AM

varun accepted this revision.Dec 18 2023, 6:30 PM

This revision is now accepted and ready to land.Dec 18 2023, 6:30 PM

CI

Harbormaster completed remote builds in B25429: Diff 35131.Jan 2 2024, 6:33 AM

Closed by commit rCOMM258c7e40fe08: [native] fix CommServicesAuthMetadata type (authored by kamil). · Explain WhyJan 2 2024, 7:06 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM258c7e40fe08: [native] fix CommServicesAuthMetadata type.

Revision Contents
Changeset List

Path

Size

native/

schema/

CommCoreModuleSchema.js

2 lines

Diff 35132

native/schema/CommCoreModuleSchema.js

	Show All 32 Lines		type SignedPrekeys = {
	+contentPrekeySignature: string,			+contentPrekeySignature: string,
	+notifPrekey: string,			+notifPrekey: string,
	+notifPrekeySignature: string,			+notifPrekeySignature: string,
	};			};

	type CommServicesAuthMetadata = {			type CommServicesAuthMetadata = {
	+userID?: ?string,			+userID?: ?string,
	+deviceID?: ?string,			+deviceID?: ?string,
	+commServicesAccessToken?: ?string,			+accessToken?: ?string,
	};			};

	interface Spec extends TurboModule {			interface Spec extends TurboModule {
	+getDraft: (key: string) => Promise<string>;			+getDraft: (key: string) => Promise<string>;
	+updateDraft: (key: string, text: string) => Promise<boolean>;			+updateDraft: (key: string, text: string) => Promise<boolean>;
	+moveDraft: (oldKey: string, newKey: string) => Promise<boolean>;			+moveDraft: (oldKey: string, newKey: string) => Promise<boolean>;
	+getClientDBStore: () => Promise<ClientDBStore>;			+getClientDBStore: () => Promise<ClientDBStore>;
	+removeAllDrafts: () => Promise<void>;			+removeAllDrafts: () => Promise<void>;
	▲ Show 20 Lines • Show All 80 Lines • Show Last 20 Lines