[CommRustModule] update `getOutboundKeys` to return all devices
ClosedPublic
Actions

Authored by kamil on Dec 18 2023, 4:26 AM.

Details

Reviewers

varun
michal
marcin

Commits

rCOMM3653d5b6fd80: [CommRustModule] update `getOutboundKeys` to return all devices

Summary

To create a session with all other devices of a given user we don't know the IDs of specific devices so we need to get all of them.
I think it's more convenient to update this method (later we can filter if we want a specific ID) rather than introducing a new JSI method.

Depends on D10372

Test Plan

Login to staging Identity (loginPasswordUser) on two devices using the same account.
Call this method and check if the result is correct (two devices).

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Dec 18 2023, 4:26 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 18 2023, 4:26 AM

remove unwrap()

kamil added a child revision: D10374: [CommRustModule] implement `getInboundKeys`.Dec 18 2023, 4:34 AM

Harbormaster completed remote builds in B25171: Diff 34786.Dec 18 2023, 5:51 AM

Harbormaster completed remote builds in B25172: Diff 34787.Dec 18 2023, 5:55 AM

kamil published this revision for review.Dec 18 2023, 6:48 AM

Look like we can waste a one-time key each time we call it because it is also returns one-time caller which will never be used, I'll create a follow-up task to fix it somehow

LGTM for me. Personally I would prefer to do some JSON parsing in C++ to return $ReadOnlyArray<...> to JS but leaving this up to you. I am resigning since it is better if someone more experienced in Rust sees this code.

michal accepted this revision.Dec 21 2023, 5:39 AM

michal added inline comments.