Page MenuHomePhabricator
Differential D10384

[CryptoModule] rename `targetUserId` -> `targetDeviceId`
ClosedPublic
Actions

Authored by kamil on Dec 18 2023, 6:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 11:07 PM
Unknown Object (File)
Mon, Mar 10, 6:59 PM
Unknown Object (File)
Feb 20 2025, 6:27 PM
Unknown Object (File)
Feb 15 2025, 8:39 PM
Unknown Object (File)
Feb 7 2025, 12:57 PM
Unknown Object (File)
Feb 6 2025, 9:39 AM
Unknown Object (File)
Feb 5 2025, 4:27 PM
Unknown Object (File)
Jan 22 2025, 6:59 PM
View All 65 Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
varun
michal
Commits
rCOMM1756fb25173a: [CryptoModule] rename `targetUserId` -> `targetDeviceId`
Summary

It is really confusing as session is created with specific device, not user.

Depends on D10383

Test Plan

Build app

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
CryptoTools/
12 lines
38 lines

Diff 35397

View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.h

// @flow // @flow
import t from 'tcomb'; import t from 'tcomb';
import type { UpdateSpec } from './update-spec.js'; import type { UpdateSpec } from './update-spec.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { MixedRawThreadInfos } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { import type {
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
} from '../../types/update-types.js'; } from '../../types/update-types.js';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
export const deleteThreadSpec: UpdateSpec< export const deleteThreadSpec: UpdateSpec<
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
> = Object.freeze({ > = Object.freeze({
generateOpsForThreadUpdates( generateOpsForThreadUpdates(
storeThreadInfos: RawThreadInfos, storeThreadInfos: MixedRawThreadInfos,
update: ThreadDeletionUpdateInfo, update: ThreadDeletionUpdateInfo,
) { ) {
if (storeThreadInfos[update.threadID]) { if (storeThreadInfos[update.threadID]) {
return [ return [
{ {
type: 'remove', type: 'remove',
payload: { payload: {
ids: [update.threadID], ids: [update.threadID],
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp

// @flow // @flow
import t from 'tcomb'; import t from 'tcomb';
import type { UpdateSpec } from './update-spec.js'; import type { UpdateSpec } from './update-spec.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { MixedRawThreadInfos } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { import type {
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
} from '../../types/update-types.js'; } from '../../types/update-types.js';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
export const deleteThreadSpec: UpdateSpec< export const deleteThreadSpec: UpdateSpec<
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
> = Object.freeze({ > = Object.freeze({
generateOpsForThreadUpdates( generateOpsForThreadUpdates(
storeThreadInfos: RawThreadInfos, storeThreadInfos: MixedRawThreadInfos,
update: ThreadDeletionUpdateInfo, update: ThreadDeletionUpdateInfo,
) { ) {
if (storeThreadInfos[update.threadID]) { if (storeThreadInfos[update.threadID]) {
return [ return [
{ {
type: 'remove', type: 'remove',
payload: { payload: {
ids: [update.threadID], ids: [update.threadID],
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines