[CryptoModule] rename `targetUserId` -> `targetDeviceId`
ClosedPublic
Actions

Authored by kamil on Dec 18 2023, 6:09 AM.

Details

Reviewers

marcin
varun
michal

Commits

rCOMM1756fb25173a: [CryptoModule] rename `targetUserId` -> `targetDeviceId`

Summary

It is really confusing as session is created with specific device, not user.

Depends on D10383

Test Plan

Build app

Diff Detail

Repository

rCOMM Comm

Branch

publish-olm-stack

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Dec 18 2023, 6:09 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 18 2023, 6:09 AM

kamil published this revision for review.Dec 18 2023, 6:55 AM

Harbormaster failed remote builds in B25183: Diff 34798!Dec 18 2023, 8:12 AM

kamil added a child revision: D10510: [CommRustModule] implement uploading one-time keys to Identity.Jan 3 2024, 7:21 AM

marcin accepted this revision.Jan 4 2024, 3:56 AM

This revision is now accepted and ready to land.Jan 4 2024, 3:56 AM

kamil removed a parent revision: D10383: [native] add button to test send encrypted content between devices.Jan 8 2024, 6:54 AM

kamil added a parent revision: D10378: [CommCoreModule] implement decrypting content with `olm` session.

This revision was landed with ongoing or failed builds.Jan 8 2024, 7:27 AM

Closed by commit rCOMM1756fb25173a: [CryptoModule] rename `targetUserId` -> `targetDeviceId` (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM1756fb25173a: [CryptoModule] rename `targetUserId` -> `targetDeviceId`.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

CryptoTools/

CryptoModule.h

12 lines

CryptoModule.cpp

38 lines

Diff 34798

View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.h