Page MenuHomePhabricator
Differential D10384

[CryptoModule] rename `targetUserId` -> `targetDeviceId`
ClosedPublic
Actions

Authored by kamil on Dec 18 2023, 6:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 11:07 PM
Unknown Object (File)
Mon, Mar 10, 6:59 PM
Unknown Object (File)
Feb 20 2025, 6:27 PM
Unknown Object (File)
Feb 15 2025, 8:39 PM
Unknown Object (File)
Feb 7 2025, 12:57 PM
Unknown Object (File)
Feb 6 2025, 9:39 AM
Unknown Object (File)
Feb 5 2025, 4:27 PM
Unknown Object (File)
Jan 22 2025, 6:59 PM
View All 65 Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
varun
michal
Commits
rCOMM1756fb25173a: [CryptoModule] rename `targetUserId` -> `targetDeviceId`
Summary

It is really confusing as session is created with specific device, not user.

Depends on D10383

Test Plan

Build app

Diff Detail

Repository
rCOMM Comm
Branch
publish-olm-stack
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
CryptoTools/
12 lines
38 lines

Diff 34798

View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.h

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines
import { import {
fullStateSyncActionType, fullStateSyncActionType,
incrementalStateSyncActionType, incrementalStateSyncActionType,
} from '../types/socket-types.js'; } from '../types/socket-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import type { import type {
LegacyRawThreadInfo, LegacyRawThreadInfo,
MinimallyEncodedRawThreadInfos, MinimallyEncodedRawThreadInfos,
RawThreadInfos, MixedRawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { import {
type ClientUpdateInfo, type ClientUpdateInfo,
processUpdatesActionType, processUpdatesActionType,
} from '../types/update-types.js'; } from '../types/update-types.js';
import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js'; import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
Show All 35 Lines
type FreshMessageStoreResult = { type FreshMessageStoreResult = {
+messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>, +messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>,
+messageStore: MessageStore, +messageStore: MessageStore,
}; };
function freshMessageStore( function freshMessageStore(
messageInfos: $ReadOnlyArray<RawMessageInfo>, messageInfos: $ReadOnlyArray<RawMessageInfo>,
truncationStatus: { [threadID: string]: MessageTruncationStatus }, truncationStatus: { [threadID: string]: MessageTruncationStatus },
currentAsOf: { +[keyserverID: string]: number }, currentAsOf: { +[keyserverID: string]: number },
threadInfos: RawThreadInfos, threadInfos: MixedRawThreadInfos,
): FreshMessageStoreResult { ): FreshMessageStoreResult {
const unshimmed = unshimMessageInfos(messageInfos); const unshimmed = unshimMessageInfos(messageInfos);
const orderedMessageInfos = sortMessageInfoList(unshimmed); const orderedMessageInfos = sortMessageInfoList(unshimmed);
const messages = _keyBy(messageID)(orderedMessageInfos); const messages = _keyBy(messageID)(orderedMessageInfos);
const messageStoreReplaceOperations = orderedMessageInfos.map( const messageStoreReplaceOperations = orderedMessageInfos.map(
messageInfo => ({ messageInfo => ({
type: 'replace', type: 'replace',
▲ Show 20 Lines • Show All 1,511 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines
import { import {
fullStateSyncActionType, fullStateSyncActionType,
incrementalStateSyncActionType, incrementalStateSyncActionType,
} from '../types/socket-types.js'; } from '../types/socket-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import type { import type {
LegacyRawThreadInfo, LegacyRawThreadInfo,
MinimallyEncodedRawThreadInfos, MinimallyEncodedRawThreadInfos,
RawThreadInfos, MixedRawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { import {
type ClientUpdateInfo, type ClientUpdateInfo,
processUpdatesActionType, processUpdatesActionType,
} from '../types/update-types.js'; } from '../types/update-types.js';
import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js'; import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
Show All 35 Lines
type FreshMessageStoreResult = { type FreshMessageStoreResult = {
+messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>, +messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>,
+messageStore: MessageStore, +messageStore: MessageStore,
}; };
function freshMessageStore( function freshMessageStore(
messageInfos: $ReadOnlyArray<RawMessageInfo>, messageInfos: $ReadOnlyArray<RawMessageInfo>,
truncationStatus: { [threadID: string]: MessageTruncationStatus }, truncationStatus: { [threadID: string]: MessageTruncationStatus },
currentAsOf: { +[keyserverID: string]: number }, currentAsOf: { +[keyserverID: string]: number },
threadInfos: RawThreadInfos, threadInfos: MixedRawThreadInfos,
): FreshMessageStoreResult { ): FreshMessageStoreResult {
const unshimmed = unshimMessageInfos(messageInfos); const unshimmed = unshimMessageInfos(messageInfos);
const orderedMessageInfos = sortMessageInfoList(unshimmed); const orderedMessageInfos = sortMessageInfoList(unshimmed);
const messages = _keyBy(messageID)(orderedMessageInfos); const messages = _keyBy(messageID)(orderedMessageInfos);
const messageStoreReplaceOperations = orderedMessageInfos.map( const messageStoreReplaceOperations = orderedMessageInfos.map(
messageInfo => ({ messageInfo => ({
type: 'replace', type: 'replace',
▲ Show 20 Lines • Show All 1,511 Lines • Show Last 20 Lines