Differential D10371
[CommCoreModule] implement method to persist `olm` account Authored by kamil on Dec 18 2023, 4:22 AM. Tags None Referenced Files
Details This code will be re-used a lot in methods introduced later in the stack - creating a separate function. In all cases, this method will be called from a task invoked on the crypto thread, since tasks are sequential and invoked in order on one thread it should result in the same order on the database thread so there is no chance to override/miss some updates on crypto account. Depends on D10370 Build the app, the rest is tested later in the stack.
Diff Detail
Event TimelineComment Actions Olm account retrieval, in-memory update and update state persistence should be a single atomic operation. This is what we should do:
Comment Actions I am afraid that I behaved too abruptly in my previous comment. Actually you code does not create any race condition provided that it is always executed from the crypto thread. Crypto thread ensures FIFO-ordered sequentiality of crypto operations so if at teh end of each crypto operation we will schedule update on the database thread that is also FIFO-ordered sequential we will be safe.
| ||||||||||||||||||||||||||||||||||