Page MenuHomePhabricator
Differential D10378

[CommCoreModule] implement decrypting content with `olm` session
ClosedPublic
Actions

Authored by kamil on Dec 18 2023, 4:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 2, 9:37 AM
Unknown Object (File)
Sun, Mar 2, 9:36 AM
Unknown Object (File)
Mon, Feb 24, 1:34 AM
Unknown Object (File)
Feb 20 2025, 6:53 PM
Unknown Object (File)
Jan 28 2025, 3:25 AM
Unknown Object (File)
Jan 22 2025, 6:59 PM
Unknown Object (File)
Jan 22 2025, 6:59 PM
Unknown Object (File)
Jan 22 2025, 6:59 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
varun
michal
Commits
rCOMM372934d77238: [CommCoreModule] implement decrypting content with `olm` session
Summary

Implemented method to decrypt content.

Depends on D10377

Test Plan

This code is really hard to test as it's impossible to verify partial results.
I generated some keys and values, verified them with olm-utils.test.js, and checked if they succeeded/failed when calling the method introduced here in the same cases as JS tests.
Full functionality tested later in the stack.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Dec 18 2023, 4:42 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 18 2023, 4:42 AM
kamil added a child revision: D10379: [lib/native] introduce handling Tunnelbroker peer-to-peer messages.Dec 18 2023, 4:48 AM
Harbormaster completed remote builds in B25177: Diff 34792.Dec 18 2023, 6:52 AM
kamil published this revision for review.Dec 18 2023, 6:52 AM
marcin added inline comments.Dec 21 2023, 3:24 AM
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
869 ↗(On Diff #34792)

This comment is relevant here as well

marcin requested changes to this revision.Dec 21 2023, 3:24 AM
This revision now requires changes to proceed.Dec 21 2023, 3:24 AM
kamil updated this revision to Diff 35144.Jan 2 2024, 8:58 AM

rebase

Harbormaster failed remote builds in B25440: Diff 35144!Jan 2 2024, 10:11 AM
marcin accepted this revision.Jan 2 2024, 11:59 PM
marcin added inline comments.
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
859 ↗(On Diff #35144)

This file contains definition of EncryptedData so perhaps we could move this constant there?

This revision is now accepted and ready to land.Jan 2 2024, 11:59 PM
kamil updated this revision to Diff 35362.Jan 8 2024, 5:23 AM

move definition to Tools.h

kamil updated this revision to Diff 35364.Jan 8 2024, 5:41 AM

rebase before landing

Harbormaster failed remote builds in B25593: Diff 35362!Jan 8 2024, 5:51 AM
Harbormaster failed remote builds in B25595: Diff 35364!Jan 8 2024, 6:08 AM
kamil added a comment.Jan 8 2024, 6:39 AM

CI failure not related - landing

This revision was landed with ongoing or failed builds.Jan 8 2024, 6:48 AM
Closed by commit rCOMM372934d77238: [CommCoreModule] implement decrypting content with `olm` session (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM372934d77238: [CommCoreModule] implement decrypting content with `olm` session.
kamil added a child revision: D10384: [CryptoModule] rename `targetUserId` -> `targetDeviceId`.Jan 8 2024, 6:54 AM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
CryptoTools/
2 lines
NativeModules/
2 lines
34 lines
_generated/
schema/
1 line

Diff 35379

View Options

native/cpp/CommonCpp/CryptoTools/Tools.h

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines "dependencies": {
"ethers": "^6.11.1", "ethers": "^6.11.1",
"expo": "47.0.14", "expo": "47.0.14",
"expo-application": "^5.1.1", "expo-application": "^5.1.1",
"expo-barcode-scanner": "~12.1.0", "expo-barcode-scanner": "~12.1.0",
"expo-dev-client": "~2.0.1", "expo-dev-client": "~2.0.1",
"expo-file-system": "~15.1.1", "expo-file-system": "~15.1.1",
"expo-font": "~11.0.1", "expo-font": "~11.0.1",
"expo-haptics": "~12.0.1", "expo-haptics": "~12.0.1",
"expo-image": "^1.2.2", "expo-image": "1.2.3",
"expo-image-manipulator": "~11.0.0", "expo-image-manipulator": "~11.0.0",
"expo-image-picker": "~14.0.2", "expo-image-picker": "~14.0.2",
"expo-media-library": "~15.0.0", "expo-media-library": "~15.0.0",
"expo-secure-store": "~12.0.0", "expo-secure-store": "~12.0.0",
"expo-splash-screen": "~0.17.4", "expo-splash-screen": "~0.17.4",
"find-root": "^1.1.0", "find-root": "^1.1.0",
"invariant": "^2.2.4", "invariant": "^2.2.4",
"lib": "0.0.1", "lib": "0.0.1",
"lodash": "^4.17.21", "lodash": "^4.17.21",
"lottie-react-native": "^5.1.4", "lottie-react-native": "^5.1.4",
"md5": "^2.2.1", "md5": "^2.2.1",
"olm": "git+https://github.com/CommE2E/olm.git#v0.2.1", "olm": "git+https://github.com/CommE2E/olm.git#v0.2.1",
"react": "18.1.0", "react": "18.1.0",
"react-native": "0.70.9", "react-native": "0.70.9",
"react-native-camera": "^3.31.0", "react-native-camera": "^3.31.0",
"react-native-device-info": "^10.3.0", "react-native-device-info": "^10.3.0",
"react-native-ffmpeg": "^0.4.4", "react-native-ffmpeg": "^0.5.2",
"react-native-figma-squircle": "^0.1.2", "react-native-figma-squircle": "^0.1.2",
"react-native-floating-action": "^1.22.0", "react-native-floating-action": "^1.22.0",
"react-native-fs": "^2.20.0", "react-native-fs": "^2.20.0",
"react-native-gesture-handler": "^2.8.0", "react-native-gesture-handler": "^2.8.0",
"react-native-in-app-message": "^1.0.2", "react-native-in-app-message": "^1.0.2",
"react-native-keyboard-input": "6.0.1", "react-native-keyboard-input": "6.0.1",
"react-native-keychain": "^8.0.0", "react-native-keychain": "^8.0.0",
"react-native-orientation-locker": "^1.5.0", "react-native-orientation-locker": "^1.5.0",
Show All 29 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines "dependencies": {
"ethers": "^6.11.1", "ethers": "^6.11.1",
"expo": "47.0.14", "expo": "47.0.14",
"expo-application": "^5.1.1", "expo-application": "^5.1.1",
"expo-barcode-scanner": "~12.1.0", "expo-barcode-scanner": "~12.1.0",
"expo-dev-client": "~2.0.1", "expo-dev-client": "~2.0.1",
"expo-file-system": "~15.1.1", "expo-file-system": "~15.1.1",
"expo-font": "~11.0.1", "expo-font": "~11.0.1",
"expo-haptics": "~12.0.1", "expo-haptics": "~12.0.1",
"expo-image": "^1.2.2", "expo-image": "1.2.3",
"expo-image-manipulator": "~11.0.0", "expo-image-manipulator": "~11.0.0",
"expo-image-picker": "~14.0.2", "expo-image-picker": "~14.0.2",
"expo-media-library": "~15.0.0", "expo-media-library": "~15.0.0",
"expo-secure-store": "~12.0.0", "expo-secure-store": "~12.0.0",
"expo-splash-screen": "~0.17.4", "expo-splash-screen": "~0.17.4",
"find-root": "^1.1.0", "find-root": "^1.1.0",
"invariant": "^2.2.4", "invariant": "^2.2.4",
"lib": "0.0.1", "lib": "0.0.1",
"lodash": "^4.17.21", "lodash": "^4.17.21",
"lottie-react-native": "^5.1.4", "lottie-react-native": "^5.1.4",
"md5": "^2.2.1", "md5": "^2.2.1",
"olm": "git+https://github.com/CommE2E/olm.git#v0.2.1", "olm": "git+https://github.com/CommE2E/olm.git#v0.2.1",
"react": "18.1.0", "react": "18.1.0",
"react-native": "0.70.9", "react-native": "0.70.9",
"react-native-camera": "^3.31.0", "react-native-camera": "^3.31.0",
"react-native-device-info": "^10.3.0", "react-native-device-info": "^10.3.0",
"react-native-ffmpeg": "^0.4.4", "react-native-ffmpeg": "^0.5.2",
"react-native-figma-squircle": "^0.1.2", "react-native-figma-squircle": "^0.1.2",
"react-native-floating-action": "^1.22.0", "react-native-floating-action": "^1.22.0",
"react-native-fs": "^2.20.0", "react-native-fs": "^2.20.0",
"react-native-gesture-handler": "^2.8.0", "react-native-gesture-handler": "^2.8.0",
"react-native-in-app-message": "^1.0.2", "react-native-in-app-message": "^1.0.2",
"react-native-keyboard-input": "6.0.1", "react-native-keyboard-input": "6.0.1",
"react-native-keychain": "^8.0.0", "react-native-keychain": "^8.0.0",
"react-native-orientation-locker": "^1.5.0", "react-native-orientation-locker": "^1.5.0",
Show All 29 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines "dependencies": {
"ethers": "^6.11.1", "ethers": "^6.11.1",
"expo": "47.0.14", "expo": "47.0.14",
"expo-application": "^5.1.1", "expo-application": "^5.1.1",
"expo-barcode-scanner": "~12.1.0", "expo-barcode-scanner": "~12.1.0",
"expo-dev-client": "~2.0.1", "expo-dev-client": "~2.0.1",
"expo-file-system": "~15.1.1", "expo-file-system": "~15.1.1",
"expo-font": "~11.0.1", "expo-font": "~11.0.1",
"expo-haptics": "~12.0.1", "expo-haptics": "~12.0.1",
"expo-image": "^1.2.2", "expo-image": "1.2.3",
"expo-image-manipulator": "~11.0.0", "expo-image-manipulator": "~11.0.0",
"expo-image-picker": "~14.0.2", "expo-image-picker": "~14.0.2",
"expo-media-library": "~15.0.0", "expo-media-library": "~15.0.0",
"expo-secure-store": "~12.0.0", "expo-secure-store": "~12.0.0",
"expo-splash-screen": "~0.17.4", "expo-splash-screen": "~0.17.4",
"find-root": "^1.1.0", "find-root": "^1.1.0",
"invariant": "^2.2.4", "invariant": "^2.2.4",
"lib": "0.0.1", "lib": "0.0.1",
"lodash": "^4.17.21", "lodash": "^4.17.21",
"lottie-react-native": "^5.1.4", "lottie-react-native": "^5.1.4",
"md5": "^2.2.1", "md5": "^2.2.1",
"olm": "git+https://github.com/CommE2E/olm.git#v0.2.1", "olm": "git+https://github.com/CommE2E/olm.git#v0.2.1",
"react": "18.1.0", "react": "18.1.0",
"react-native": "0.70.9", "react-native": "0.70.9",
"react-native-camera": "^3.31.0", "react-native-camera": "^3.31.0",
"react-native-device-info": "^10.3.0", "react-native-device-info": "^10.3.0",
"react-native-ffmpeg": "^0.4.4", "react-native-ffmpeg": "^0.5.2",
"react-native-figma-squircle": "^0.1.2", "react-native-figma-squircle": "^0.1.2",
"react-native-floating-action": "^1.22.0", "react-native-floating-action": "^1.22.0",
"react-native-fs": "^2.20.0", "react-native-fs": "^2.20.0",
"react-native-gesture-handler": "^2.8.0", "react-native-gesture-handler": "^2.8.0",
"react-native-in-app-message": "^1.0.2", "react-native-in-app-message": "^1.0.2",
"react-native-keyboard-input": "6.0.1", "react-native-keyboard-input": "6.0.1",
"react-native-keychain": "^8.0.0", "react-native-keychain": "^8.0.0",
"react-native-orientation-locker": "^1.5.0", "react-native-orientation-locker": "^1.5.0",
Show All 29 Lines
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines "dependencies": {
"ethers": "^6.11.1", "ethers": "^6.11.1",
"expo": "47.0.14", "expo": "47.0.14",
"expo-application": "^5.1.1", "expo-application": "^5.1.1",
"expo-barcode-scanner": "~12.1.0", "expo-barcode-scanner": "~12.1.0",
"expo-dev-client": "~2.0.1", "expo-dev-client": "~2.0.1",
"expo-file-system": "~15.1.1", "expo-file-system": "~15.1.1",
"expo-font": "~11.0.1", "expo-font": "~11.0.1",
"expo-haptics": "~12.0.1", "expo-haptics": "~12.0.1",
"expo-image": "^1.2.2", "expo-image": "1.2.3",
"expo-image-manipulator": "~11.0.0", "expo-image-manipulator": "~11.0.0",
"expo-image-picker": "~14.0.2", "expo-image-picker": "~14.0.2",
"expo-media-library": "~15.0.0", "expo-media-library": "~15.0.0",
"expo-secure-store": "~12.0.0", "expo-secure-store": "~12.0.0",
"expo-splash-screen": "~0.17.4", "expo-splash-screen": "~0.17.4",
"find-root": "^1.1.0", "find-root": "^1.1.0",
"invariant": "^2.2.4", "invariant": "^2.2.4",
"lib": "0.0.1", "lib": "0.0.1",
"lodash": "^4.17.21", "lodash": "^4.17.21",
"lottie-react-native": "^5.1.4", "lottie-react-native": "^5.1.4",
"md5": "^2.2.1", "md5": "^2.2.1",
"olm": "git+https://github.com/CommE2E/olm.git#v0.2.1", "olm": "git+https://github.com/CommE2E/olm.git#v0.2.1",
"react": "18.1.0", "react": "18.1.0",
"react-native": "0.70.9", "react-native": "0.70.9",
"react-native-camera": "^3.31.0", "react-native-camera": "^3.31.0",
"react-native-device-info": "^10.3.0", "react-native-device-info": "^10.3.0",
"react-native-ffmpeg": "^0.4.4", "react-native-ffmpeg": "^0.5.2",
"react-native-figma-squircle": "^0.1.2", "react-native-figma-squircle": "^0.1.2",
"react-native-floating-action": "^1.22.0", "react-native-floating-action": "^1.22.0",
"react-native-fs": "^2.20.0", "react-native-fs": "^2.20.0",
"react-native-gesture-handler": "^2.8.0", "react-native-gesture-handler": "^2.8.0",
"react-native-in-app-message": "^1.0.2", "react-native-in-app-message": "^1.0.2",
"react-native-keyboard-input": "6.0.1", "react-native-keyboard-input": "6.0.1",
"react-native-keychain": "^8.0.0", "react-native-keychain": "^8.0.0",
"react-native-orientation-locker": "^1.5.0", "react-native-orientation-locker": "^1.5.0",
Show All 29 Lines
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...