Page MenuHomePhabricator
Differential D10511

[lib/shared] clean `RefreshKeyRequest` type
ClosedPublic
Actions

Authored by kamil on Jan 3 2024, 7:25 AM.
Tags
None
Referenced Files
F6077909: D10511.id35523.diff
Sun, Apr 20, 4:02 PM
F6070689: D10511.id35425.diff
Sun, Apr 20, 1:17 PM
Unknown Object (File)
Sun, Apr 20, 12:46 AM
Unknown Object (File)
Sat, Apr 19, 9:23 PM
Unknown Object (File)
Sat, Apr 19, 9:01 PM
Unknown Object (File)
Sat, Apr 19, 3:30 AM
Unknown Object (File)
Fri, Apr 18, 7:28 AM
Unknown Object (File)
Wed, Apr 16, 2:30 AM
View All 98 Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
varun
michal
Commits
rCOMM10771ee94c00: [lib/shared] clean `RefreshKeyRequest` type
Summary

This is not a separate message type, this is a message sent as a payload of MessageToDevice.

The following change from D10379

Depends on D10510

Test Plan

Rust/Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jan 3 2024, 7:25 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 3 2024, 7:25 AM
Harbormaster completed remote builds in B25451: Diff 35159.Jan 3 2024, 8:00 AM
kamil added a child revision: D10526: [native] implement uploading one-time keys.Jan 4 2024, 3:11 AM
kamil published this revision for review.Jan 4 2024, 3:20 AM
kamil updated this revision to Diff 35423.Jan 9 2024, 2:43 AM

rebase

kamil edited the summary of this revision. (Show Details)Jan 9 2024, 2:51 AM
kamil added 1 blocking reviewer(s): michal.
Harbormaster failed remote builds in B25624: Diff 35423!Jan 9 2024, 2:55 AM
michal accepted this revision.Jan 9 2024, 2:58 AM
This revision is now accepted and ready to land.Jan 9 2024, 2:58 AM
kamil updated this revision to Diff 35425.Jan 9 2024, 3:11 AM

CI

Harbormaster completed remote builds in B25626: Diff 35425.Jan 9 2024, 3:36 AM
Closed by commit rCOMM10771ee94c00: [lib/shared] clean `RefreshKeyRequest` type (authored by kamil). · Explain WhyJan 11 2024, 5:28 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM10771ee94c00: [lib/shared] clean `RefreshKeyRequest` type.

Revision Contents
Changeset List

PathSize
keyserver/
src/
socket/
8 lines
lib/
types/
tunnelbroker/
7 lines
shared/
tunnelbroker_messages/
src/
messages/
7 lines

Diff 35523

View Options

keyserver/src/socket/tunnelbroker-socket.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
verifyInviteLink, useVerifyInviteLink,
verifyInviteLinkActionTypes, verifyInviteLinkActionTypes,
} from 'lib/actions/link-actions.js'; } from 'lib/actions/link-actions.js';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { useLegacyAshoatKeyserverCall } from 'lib/utils/action-utils.js';
import { useDispatchActionPromise } from 'lib/utils/redux-promise-utils.js'; import { useDispatchActionPromise } from 'lib/utils/redux-promise-utils.js';
import { useDispatch } from 'lib/utils/redux-utils.js'; import { useDispatch } from 'lib/utils/redux-utils.js';
import AcceptInviteModal from './accept-invite-modal.react.js'; import AcceptInviteModal from './accept-invite-modal.react.js';
import { updateNavInfoActionType } from '../redux/action-types.js'; import { updateNavInfoActionType } from '../redux/action-types.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
function InviteLinkHandler(): null { function InviteLinkHandler(): null {
const inviteSecret = useSelector(state => state.navInfo.inviteSecret); const inviteSecret = useSelector(state => state.navInfo.inviteSecret);
const loggedIn = useSelector(isLoggedIn); const loggedIn = useSelector(isLoggedIn);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const dispatch = useDispatch(); const dispatch = useDispatch();
const validateLink = useLegacyAshoatKeyserverCall(verifyInviteLink); const validateLink = useVerifyInviteLink();
const { pushModal } = useModalContext(); const { pushModal } = useModalContext();
React.useEffect(() => { React.useEffect(() => {
if (!inviteSecret || !loggedIn) { if (!inviteSecret || !loggedIn) {
return; return;
} }
dispatch({ dispatch({
type: updateNavInfoActionType, type: updateNavInfoActionType,
payload: { inviteSecret: null }, payload: { inviteSecret: null },
Show All 31 Lines
View Options

lib/types/tunnelbroker/keys-types.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
verifyInviteLink, useVerifyInviteLink,
verifyInviteLinkActionTypes, verifyInviteLinkActionTypes,
} from 'lib/actions/link-actions.js'; } from 'lib/actions/link-actions.js';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { useLegacyAshoatKeyserverCall } from 'lib/utils/action-utils.js';
import { useDispatchActionPromise } from 'lib/utils/redux-promise-utils.js'; import { useDispatchActionPromise } from 'lib/utils/redux-promise-utils.js';
import { useDispatch } from 'lib/utils/redux-utils.js'; import { useDispatch } from 'lib/utils/redux-utils.js';
import AcceptInviteModal from './accept-invite-modal.react.js'; import AcceptInviteModal from './accept-invite-modal.react.js';
import { updateNavInfoActionType } from '../redux/action-types.js'; import { updateNavInfoActionType } from '../redux/action-types.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
function InviteLinkHandler(): null { function InviteLinkHandler(): null {
const inviteSecret = useSelector(state => state.navInfo.inviteSecret); const inviteSecret = useSelector(state => state.navInfo.inviteSecret);
const loggedIn = useSelector(isLoggedIn); const loggedIn = useSelector(isLoggedIn);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const dispatch = useDispatch(); const dispatch = useDispatch();
const validateLink = useLegacyAshoatKeyserverCall(verifyInviteLink); const validateLink = useVerifyInviteLink();
const { pushModal } = useModalContext(); const { pushModal } = useModalContext();
React.useEffect(() => { React.useEffect(() => {
if (!inviteSecret || !loggedIn) { if (!inviteSecret || !loggedIn) {
return; return;
} }
dispatch({ dispatch({
type: updateNavInfoActionType, type: updateNavInfoActionType,
payload: { inviteSecret: null }, payload: { inviteSecret: null },
Show All 31 Lines
View Options

lib/types/tunnelbroker/messages.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
verifyInviteLink, useVerifyInviteLink,
verifyInviteLinkActionTypes, verifyInviteLinkActionTypes,
} from 'lib/actions/link-actions.js'; } from 'lib/actions/link-actions.js';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { useLegacyAshoatKeyserverCall } from 'lib/utils/action-utils.js';
import { useDispatchActionPromise } from 'lib/utils/redux-promise-utils.js'; import { useDispatchActionPromise } from 'lib/utils/redux-promise-utils.js';
import { useDispatch } from 'lib/utils/redux-utils.js'; import { useDispatch } from 'lib/utils/redux-utils.js';
import AcceptInviteModal from './accept-invite-modal.react.js'; import AcceptInviteModal from './accept-invite-modal.react.js';
import { updateNavInfoActionType } from '../redux/action-types.js'; import { updateNavInfoActionType } from '../redux/action-types.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
function InviteLinkHandler(): null { function InviteLinkHandler(): null {
const inviteSecret = useSelector(state => state.navInfo.inviteSecret); const inviteSecret = useSelector(state => state.navInfo.inviteSecret);
const loggedIn = useSelector(isLoggedIn); const loggedIn = useSelector(isLoggedIn);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const dispatch = useDispatch(); const dispatch = useDispatch();
const validateLink = useLegacyAshoatKeyserverCall(verifyInviteLink); const validateLink = useVerifyInviteLink();
const { pushModal } = useModalContext(); const { pushModal } = useModalContext();
React.useEffect(() => { React.useEffect(() => {
if (!inviteSecret || !loggedIn) { if (!inviteSecret || !loggedIn) {
return; return;
} }
dispatch({ dispatch({
type: updateNavInfoActionType, type: updateNavInfoActionType,
payload: { inviteSecret: null }, payload: { inviteSecret: null },
Show All 31 Lines
View Options

shared/tunnelbroker_messages/src/messages/mod.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
verifyInviteLink, useVerifyInviteLink,
verifyInviteLinkActionTypes, verifyInviteLinkActionTypes,
} from 'lib/actions/link-actions.js'; } from 'lib/actions/link-actions.js';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { useLegacyAshoatKeyserverCall } from 'lib/utils/action-utils.js';
import { useDispatchActionPromise } from 'lib/utils/redux-promise-utils.js'; import { useDispatchActionPromise } from 'lib/utils/redux-promise-utils.js';
import { useDispatch } from 'lib/utils/redux-utils.js'; import { useDispatch } from 'lib/utils/redux-utils.js';
import AcceptInviteModal from './accept-invite-modal.react.js'; import AcceptInviteModal from './accept-invite-modal.react.js';
import { updateNavInfoActionType } from '../redux/action-types.js'; import { updateNavInfoActionType } from '../redux/action-types.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
function InviteLinkHandler(): null { function InviteLinkHandler(): null {
const inviteSecret = useSelector(state => state.navInfo.inviteSecret); const inviteSecret = useSelector(state => state.navInfo.inviteSecret);
const loggedIn = useSelector(isLoggedIn); const loggedIn = useSelector(isLoggedIn);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const dispatch = useDispatch(); const dispatch = useDispatch();
const validateLink = useLegacyAshoatKeyserverCall(verifyInviteLink); const validateLink = useVerifyInviteLink();
const { pushModal } = useModalContext(); const { pushModal } = useModalContext();
React.useEffect(() => { React.useEffect(() => {
if (!inviteSecret || !loggedIn) { if (!inviteSecret || !loggedIn) {
return; return;
} }
dispatch({ dispatch({
type: updateNavInfoActionType, type: updateNavInfoActionType,
payload: { inviteSecret: null }, payload: { inviteSecret: null },
Show All 31 Lines