Page MenuHomePhabricator
Differential D10511

[lib/shared] clean `RefreshKeyRequest` type
ClosedPublic
Actions

Authored by kamil on Jan 3 2024, 7:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 4:02 PM
Unknown Object (File)
Sun, Apr 20, 1:17 PM
Unknown Object (File)
Sun, Apr 20, 12:46 AM
Unknown Object (File)
Sat, Apr 19, 9:23 PM
Unknown Object (File)
Sat, Apr 19, 9:01 PM
Unknown Object (File)
Sat, Apr 19, 3:30 AM
Unknown Object (File)
Fri, Apr 18, 7:28 AM
Unknown Object (File)
Wed, Apr 16, 2:30 AM
View All 98 Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
varun
michal
Commits
rCOMM10771ee94c00: [lib/shared] clean `RefreshKeyRequest` type
Summary

This is not a separate message type, this is a message sent as a payload of MessageToDevice.

The following change from D10379

Depends on D10510

Test Plan

Rust/Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jan 3 2024, 7:25 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 3 2024, 7:25 AM
Harbormaster completed remote builds in B25451: Diff 35159.Jan 3 2024, 8:00 AM
kamil added a child revision: D10526: [native] implement uploading one-time keys.Jan 4 2024, 3:11 AM
kamil published this revision for review.Jan 4 2024, 3:20 AM
kamil updated this revision to Diff 35423.Jan 9 2024, 2:43 AM

rebase

kamil edited the summary of this revision. (Show Details)Jan 9 2024, 2:51 AM
kamil added 1 blocking reviewer(s): michal.
Harbormaster failed remote builds in B25624: Diff 35423!Jan 9 2024, 2:55 AM
michal accepted this revision.Jan 9 2024, 2:58 AM
This revision is now accepted and ready to land.Jan 9 2024, 2:58 AM
kamil updated this revision to Diff 35425.Jan 9 2024, 3:11 AM

CI

Harbormaster completed remote builds in B25626: Diff 35425.Jan 9 2024, 3:36 AM
Closed by commit rCOMM10771ee94c00: [lib/shared] clean `RefreshKeyRequest` type (authored by kamil). · Explain WhyJan 11 2024, 5:28 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM10771ee94c00: [lib/shared] clean `RefreshKeyRequest` type.

Revision Contents
Changeset List

PathSize
keyserver/
src/
socket/
8 lines
lib/
types/
tunnelbroker/
7 lines
shared/
tunnelbroker_messages/
src/
messages/
7 lines

Diff 35425

View Options

keyserver/src/socket/tunnelbroker-socket.js

  • This file was copied to shared/websocket_messages/Cargo.lock.
This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

lib/types/tunnelbroker/keys-types.js

  • This file was copied to shared/websocket_messages/Cargo.lock.
This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

lib/types/tunnelbroker/messages.js

  • This file was copied to shared/websocket_messages/Cargo.lock.
This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

shared/tunnelbroker_messages/src/messages/mod.rs

  • This file was copied to shared/websocket_messages/Cargo.lock.
This file contains generated code, which does not normally need to be reviewed. Show File Contents