Paths

Table of Contentst

Differential D10378

[CommCoreModule] implement decrypting content with `olm` session
ClosedPublic
Actions

Authored by kamil on Dec 18 2023, 4:42 AM.

Tags

None

Referenced Files

	F2170697: D10378.diff
	Tue, Jul 2, 3:19 PM

	Unknown Object (File)
	Mon, Jul 1, 12:13 AM

	Unknown Object (File)
	Fri, Jun 28, 4:09 AM

	Unknown Object (File)
	Tue, Jun 25, 4:32 PM

	Unknown Object (File)
	Mon, Jun 24, 10:04 PM

	Unknown Object (File)
	Mon, Jun 24, 5:42 PM

	Unknown Object (File)
	Mon, Jun 24, 3:47 PM

	Unknown Object (File)
	Sun, Jun 23, 10:18 AM

View All 51 Files

Subscribers

Details

Reviewers

marcin
varun
michal

Commits

rCOMM372934d77238: [CommCoreModule] implement decrypting content with `olm` session

Summary

Implemented method to decrypt content.

Depends on D10377

Test Plan

This code is really hard to test as it's impossible to verify partial results.
I generated some keys and values, verified them with olm-utils.test.js, and checked if they succeeded/failed when calling the method introduced here in the same cases as JS tests.
Full functionality tested later in the stack.

Diff Detail

Repository

Branch

publish-olm-stack

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Dec 18 2023, 4:42 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 18 2023, 4:42 AM

kamil added a child revision: D10379: [lib/native] introduce handling Tunnelbroker peer-to-peer messages.Dec 18 2023, 4:48 AM

Harbormaster completed remote builds in B25177: Diff 34792.Dec 18 2023, 6:52 AM

kamil published this revision for review.Dec 18 2023, 6:52 AM

marcin added inline comments.Dec 21 2023, 3:24 AM

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
869	This comment is relevant here as well

marcin requested changes to this revision.Dec 21 2023, 3:24 AM

This revision now requires changes to proceed.Dec 21 2023, 3:24 AM

rebase

Harbormaster failed remote builds in B25440: Diff 35144!Jan 2 2024, 10:11 AM

marcin accepted this revision.Jan 2 2024, 11:59 PM

marcin added inline comments.

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
859 ↗	(On Diff #35144)	This file contains definition of `EncryptedData` so perhaps we could move this constant there?

This revision is now accepted and ready to land.Jan 2 2024, 11:59 PM

move definition to Tools.h

rebase before landing

Harbormaster failed remote builds in B25593: Diff 35362!Jan 8 2024, 5:51 AM

Harbormaster failed remote builds in B25595: Diff 35364!Jan 8 2024, 6:08 AM

CI failure not related - landing

This revision was landed with ongoing or failed builds.Jan 8 2024, 6:48 AM

Closed by commit rCOMM372934d77238: [CommCoreModule] implement decrypting content with `olm` session (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM372934d77238: [CommCoreModule] implement decrypting content with `olm` session.

kamil added a child revision: D10384: [CryptoModule] rename `targetUserId` -> `targetDeviceId`.Jan 8 2024, 6:54 AM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.h

2 lines

CommCoreModule.cpp

35 lines

_generated/

commJSI-generated.cpp

schema/

CommCoreModuleSchema.js

1 line

Diff 34792

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI.h

Loading...

native/schema/CommCoreModuleSchema.js

Loading...