Page MenuHomePhabricator

[CommRustModule] improve params capturing
ClosedPublic

Authored by kamil on Jan 5 2024, 2:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 6, 3:05 AM
Unknown Object (File)
Tue, Mar 4, 3:51 PM
Unknown Object (File)
Thu, Feb 20, 6:14 PM
Unknown Object (File)
Thu, Feb 20, 6:14 PM
Unknown Object (File)
Thu, Feb 20, 6:14 PM
Unknown Object (File)
Thu, Feb 20, 6:14 PM
Unknown Object (File)
Thu, Feb 20, 4:22 PM
Unknown Object (File)
Tue, Feb 18, 9:14 AM
Subscribers

Details

Summary

Addresses https://phab.comm.dev/D10510#inline-64080.

Alternative is using std::shared_ptr, but I don't think is safe because as far as I know jsi::* objects lifetime is managed by the JavaScript runtime, is tied to the JavaScript garbage collector, not by C++ here itself, so I am afraid it could potentially lead to dangling pointers.

Depends on D10530

Test Plan

Test entire stack (it uses methods here).

Diff Detail

Repository
rCOMM Comm
Branch
publish-olm-stack-3
Lint
No Lint Coverage
Unit
No Test Coverage