Page MenuHomePhabricator

[lib] refactor keyserver register in `keyserver-reducer` to ops
ClosedPublic

Authored by kamil on Jan 22 2024, 3:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 12:03 AM
Unknown Object (File)
Oct 15 2024, 11:17 AM
Unknown Object (File)
Oct 15 2024, 11:17 AM
Unknown Object (File)
Oct 15 2024, 11:17 AM
Unknown Object (File)
Oct 15 2024, 11:16 AM
Unknown Object (File)
Sep 28 2024, 4:24 PM
Unknown Object (File)
Sep 5 2024, 5:26 AM
Unknown Object (File)
Sep 4 2024, 7:43 AM
Subscribers

Details

Summary

Convert logic to ops approach.

Creating separate diff because I am a bit confused - @inka is modifying the state instead of returning on purpose?

Test Plan

Register new user on native and make sure state is properly set

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Jan 22 2024, 6:35 AM

Creating separate diff because I am a bit confused - @inka is modifying the state instead of returning on purpose?

I must have missed that in D9820, it should be fine to return, since we don't do anything with the state later in the reducer.

Please add a test plan or explain why N/A

In D10767#310649, @inka wrote:

Creating separate diff because I am a bit confused - @inka is modifying the state instead of returning on purpose?

I must have missed that in D9820, it should be fine to return, since we don't do anything with the state later in the reducer.

Thank for response

Please add a test plan or explain why N/A

Updated

This revision is now accepted and ready to land.Jan 29 2024, 1:46 AM