Page MenuHomePhabricator
Differential D10781

[SQLite] implement processing keyserver store ops on worker
ClosedPublic
Actions

Authored by kamil on Jan 22 2024, 5:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 9:17 AM
Unknown Object (File)
Tue, Apr 1, 8:12 AM
Unknown Object (File)
Sun, Mar 30, 7:06 AM
Unknown Object (File)
Sat, Mar 29, 10:02 PM
Unknown Object (File)
Sat, Mar 29, 9:46 PM
Unknown Object (File)
Mon, Mar 24, 9:38 AM
Unknown Object (File)
Fri, Mar 21, 2:56 PM
Unknown Object (File)
Mar 8 2025, 7:17 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
Commits
rCOMM9c42fe342b5e: [SQLite] implement processing keyserver store ops on worker
Summary

Code for web worker

Depends on D10780

Test Plan

Call this code:

const databaseModule = await getDatabaseModule();

let data = await databaseModule.schedule({
  type: workerRequestMessageTypes.GET_CLIENT_STORE,
});
console.log(data.store.keyservers);

await databaseModule.schedule({
  type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,
  storeOperations: {
    keyserverStoreOperations: [
      {
        type: 'replace_keyserver',
        payload: {
          id: '1',
          keyserverInfo: 'fdfd',
        },
      },
      {
        type: 'replace_keyserver',
        payload: {
          id: '2',
          keyserverInfo: 'fdfd',
        },
      },
    ],
  },
});

data = await databaseModule.schedule({
  type: workerRequestMessageTypes.GET_CLIENT_STORE,
});
console.log(data.store.keyservers);

await databaseModule.schedule({
  type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,
  storeOperations: {
    keyserverStoreOperations: [
      {
        type: 'replace_keyserver',
        payload: {
          id: '2',
          keyserverInfo: 'fdfd45454545',
        },
      },
    ],
  },
});

data = await databaseModule.schedule({
  type: workerRequestMessageTypes.GET_CLIENT_STORE,
});
console.log(data.store.keyservers);

await databaseModule.schedule({
  type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,
  storeOperations: {
    keyserverStoreOperations: [
      {
        type: 'remove_keyservers',
        payload: {
          ids: ['1'],
        },
      },
    ],
  },
});

data = await databaseModule.schedule({
  type: workerRequestMessageTypes.GET_CLIENT_STORE,
});
console.log(data.store.keyservers);

await databaseModule.schedule({
  type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,
  storeOperations: {
    keyserverStoreOperations: [
      {
        type: 'remove_all_keyservers',
      },
    ],
  },
});

data = await databaseModule.schedule({
  type: workerRequestMessageTypes.GET_CLIENT_STORE,
});
console.log(data.store.keyservers);

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jan 22 2024, 5:32 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 22 2024, 5:32 AM
kamil added a child revision: D10784: [native][web] migrate keyservers to SQLite.Jan 22 2024, 5:51 AM
Harbormaster completed remote builds in B26023: Diff 35957.Jan 22 2024, 6:11 AM
kamil published this revision for review.Jan 22 2024, 6:41 AM
inka accepted this revision.Jan 22 2024, 9:56 AM
This revision is now accepted and ready to land.Jan 22 2024, 9:56 AM
ashoat mentioned this in D10780: [SQLite] implement C++ code to get keyservers.Jan 23 2024, 8:57 AM
kamil updated this revision to Diff 36566.Feb 1 2024, 5:44 PM

rebase

kamil edited the test plan for this revision. (Show Details)Feb 1 2024, 5:44 PM
Harbormaster completed remote builds in B26448: Diff 36566.Feb 1 2024, 6:03 PM
kamil edited parent revisions, added: D10917: [web] update `getClientStore` name; removed: D10780: [SQLite] implement C++ code to get keyservers.Feb 2 2024, 3:13 AM
Closed by commit rCOMM9c42fe342b5e: [SQLite] implement processing keyserver store ops on worker (authored by kamil). · Explain WhyFeb 5 2024, 11:23 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM9c42fe342b5e: [SQLite] implement processing keyserver store ops on worker.

Revision Contents
Changeset List

PathSize
lib/
types/
6 lines
web/
database/
worker/
49 lines

Diff 35957

View Options

lib/types/store-ops-types.js

// @flow // @flow
import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { View, Text } from 'react-native';
import { ScrollView } from 'react-native-gesture-handler';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import type { RolesNavigationProp } from './roles-navigator.react.js'; import type { RolesNavigationProp } from './roles-navigator.react.js';
import Button from '../components/button.react.js';
import CommIcon from '../components/comm-icon.react.js';
import type { NavigationRoute } from '../navigation/route-names.js'; import type { NavigationRoute } from '../navigation/route-names.js';
import { useStyles } from '../themes/colors.js';
export type CommunityRolesScreenParams = { export type CommunityRolesScreenParams = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
type CommunityRolesScreenProps = { type CommunityRolesScreenProps = {
+navigation: RolesNavigationProp<'CommunityRolesScreen'>, +navigation: RolesNavigationProp<'CommunityRolesScreen'>,
+route: NavigationRoute<'CommunityRolesScreen'>, +route: NavigationRoute<'CommunityRolesScreen'>,
}; };
// eslint-disable-next-line no-unused-vars
function CommunityRolesScreen(props: CommunityRolesScreenProps): React.Node { function CommunityRolesScreen(props: CommunityRolesScreenProps): React.Node {
return null; const { threadInfo } = props.route.params;
const styles = useStyles(unboundStyles);
const roleNames = React.useMemo(() => {
const roleIDsToNames = {};
Object.keys(threadInfo.roles).forEach(roleID => {
roleIDsToNames[roleID] = threadInfo.roles[roleID].name;
});
return roleIDsToNames;
}, [threadInfo.roles]);
const roleNamesToMembers = React.useMemo(() => {
const roleNamesToMemberCount = {};
threadInfo.members.forEach(member => {
const roleID = member.role;
invariant(roleID, 'Community member should have a role');
const roleName = roleNames[roleID];
if (roleNamesToMemberCount[roleName] !== undefined) {
roleNamesToMemberCount[roleName] += 1;
} else {
roleNamesToMemberCount[roleName] = 1;
}
});
// For all commnity roles with no members, add them to the list with 0
Object.keys(roleNames).forEach(roleName => {
if (roleNamesToMemberCount[roleNames[roleName]] === undefined) {
roleNamesToMemberCount[roleNames[roleName]] = 0;
}
});
return roleNamesToMemberCount;
}, [threadInfo.members, roleNames]);
const rolePanelList = React.useMemo(() => {
const rolePanelEntries = [];
Object.keys(roleNamesToMembers).forEach(roleName => {
rolePanelEntries.push(
<View key={roleName} style={styles.rolePanelEntry}>
<Text style={styles.rolePanelNameEntry}>{roleName}</Text>
<Text style={styles.rolePanelCountEntry}>
{roleNamesToMembers[roleName]}
<CommIcon name="user-filled" size={14} />
</Text>
</View>,
);
});
return rolePanelEntries;
}, [
roleNamesToMembers,
styles.rolePanelEntry,
styles.rolePanelCountEntry,
styles.rolePanelNameEntry,
]);
const navigateToCreateRole = React.useCallback(() => {}, []);
return (
<View>
<View style={styles.rolesInfoContainer}>
<Text style={styles.rolesInfoText}>
Roles help you group community members together and assign them
certain permissions. The Admins and Members roles are set by default
and cannot be edited or deleted. {'\n\n'}
When people join the community, they are automatically assigned the
Members role.
</Text>
</View>
<View style={styles.rolesPanel}>
<View style={styles.rolePanelHeadersContainer}>
<Text style={styles.rolePanelHeaderLeft}>ROLES</Text>
<Text style={styles.rolePanelHeaderRight}>MEMBERS</Text>
</View>
<ScrollView style={styles.rolePanelList}>{rolePanelList}</ScrollView>
<View style={styles.buttonContainer}>
<Button
style={styles.createRoleButton}
onPress={navigateToCreateRole}
>
<Text style={styles.createRoleButtonText}>Create Role</Text>
</Button>
</View>
</View>
</View>
);
} }
const unboundStyles = {
rolesInfoContainer: {
backgroundColor: 'panelForeground',
padding: 16,
},
rolesInfoText: {
color: 'panelBackgroundLabel',
fontSize: 14,
},
rolesPanel: {
marginTop: 30,
},
rolePanelHeadersContainer: {
flexDirection: 'row',
justifyContent: 'space-between',
alignItems: 'center',
paddingHorizontal: 8,
},
rolePanelHeaderLeft: {
color: 'panelBackgroundLabel',
fontSize: 14,
},
rolePanelHeaderRight: {
color: 'panelBackgroundLabel',
fontSize: 14,
marginRight: 72,
},
rolePanelList: {
backgroundColor: 'panelForeground',
marginTop: 8,
padding: 4,
maxHeight: 400,
},
rolePanelEntry: {
flexDirection: 'row',
justifyContent: 'space-between',
alignItems: 'center',
padding: 8,
},
rolePanelNameEntry: {
color: 'whiteText',
fontWeight: '600',
fontSize: 14,
},
rolePanelCountEntry: {
color: 'whiteText',
fontWeight: '600',
fontSize: 14,
marginRight: 72,
padding: 8,
},
buttonContainer: {
backgroundColor: 'panelForeground',
padding: 2,
},
createRoleButton: {
justifyContent: 'center',
alignItems: 'center',
margin: 10,
backgroundColor: 'purpleButton',
height: 48,
borderRadius: 10,
},
createRoleButtonText: {
color: 'whiteText',
fontSize: 16,
fontWeight: '500',
},
};
export default CommunityRolesScreen; export default CommunityRolesScreen;
View Options

web/database/worker/process-operations.js

// @flow // @flow
import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { View, Text } from 'react-native';
import { ScrollView } from 'react-native-gesture-handler';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import type { RolesNavigationProp } from './roles-navigator.react.js'; import type { RolesNavigationProp } from './roles-navigator.react.js';
import Button from '../components/button.react.js';
import CommIcon from '../components/comm-icon.react.js';
import type { NavigationRoute } from '../navigation/route-names.js'; import type { NavigationRoute } from '../navigation/route-names.js';
import { useStyles } from '../themes/colors.js';
export type CommunityRolesScreenParams = { export type CommunityRolesScreenParams = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
type CommunityRolesScreenProps = { type CommunityRolesScreenProps = {
+navigation: RolesNavigationProp<'CommunityRolesScreen'>, +navigation: RolesNavigationProp<'CommunityRolesScreen'>,
+route: NavigationRoute<'CommunityRolesScreen'>, +route: NavigationRoute<'CommunityRolesScreen'>,
}; };
// eslint-disable-next-line no-unused-vars
function CommunityRolesScreen(props: CommunityRolesScreenProps): React.Node { function CommunityRolesScreen(props: CommunityRolesScreenProps): React.Node {
return null; const { threadInfo } = props.route.params;
const styles = useStyles(unboundStyles);
const roleNames = React.useMemo(() => {
const roleIDsToNames = {};
Object.keys(threadInfo.roles).forEach(roleID => {
roleIDsToNames[roleID] = threadInfo.roles[roleID].name;
});
return roleIDsToNames;
}, [threadInfo.roles]);
const roleNamesToMembers = React.useMemo(() => {
const roleNamesToMemberCount = {};
threadInfo.members.forEach(member => {
const roleID = member.role;
invariant(roleID, 'Community member should have a role');
const roleName = roleNames[roleID];
if (roleNamesToMemberCount[roleName] !== undefined) {
roleNamesToMemberCount[roleName] += 1;
} else {
roleNamesToMemberCount[roleName] = 1;
}
});
// For all commnity roles with no members, add them to the list with 0
Object.keys(roleNames).forEach(roleName => {
if (roleNamesToMemberCount[roleNames[roleName]] === undefined) {
roleNamesToMemberCount[roleNames[roleName]] = 0;
}
});
return roleNamesToMemberCount;
}, [threadInfo.members, roleNames]);
const rolePanelList = React.useMemo(() => {
const rolePanelEntries = [];
Object.keys(roleNamesToMembers).forEach(roleName => {
rolePanelEntries.push(
<View key={roleName} style={styles.rolePanelEntry}>
<Text style={styles.rolePanelNameEntry}>{roleName}</Text>
<Text style={styles.rolePanelCountEntry}>
{roleNamesToMembers[roleName]}
<CommIcon name="user-filled" size={14} />
</Text>
</View>,
);
});
return rolePanelEntries;
}, [
roleNamesToMembers,
styles.rolePanelEntry,
styles.rolePanelCountEntry,
styles.rolePanelNameEntry,
]);
const navigateToCreateRole = React.useCallback(() => {}, []);
return (
<View>
<View style={styles.rolesInfoContainer}>
<Text style={styles.rolesInfoText}>
Roles help you group community members together and assign them
certain permissions. The Admins and Members roles are set by default
and cannot be edited or deleted. {'\n\n'}
When people join the community, they are automatically assigned the
Members role.
</Text>
</View>
<View style={styles.rolesPanel}>
<View style={styles.rolePanelHeadersContainer}>
<Text style={styles.rolePanelHeaderLeft}>ROLES</Text>
<Text style={styles.rolePanelHeaderRight}>MEMBERS</Text>
</View>
<ScrollView style={styles.rolePanelList}>{rolePanelList}</ScrollView>
<View style={styles.buttonContainer}>
<Button
style={styles.createRoleButton}
onPress={navigateToCreateRole}
>
<Text style={styles.createRoleButtonText}>Create Role</Text>
</Button>
</View>
</View>
</View>
);
} }
const unboundStyles = {
rolesInfoContainer: {
backgroundColor: 'panelForeground',
padding: 16,
},
rolesInfoText: {
color: 'panelBackgroundLabel',
fontSize: 14,
},
rolesPanel: {
marginTop: 30,
},
rolePanelHeadersContainer: {
flexDirection: 'row',
justifyContent: 'space-between',
alignItems: 'center',
paddingHorizontal: 8,
},
rolePanelHeaderLeft: {
color: 'panelBackgroundLabel',
fontSize: 14,
},
rolePanelHeaderRight: {
color: 'panelBackgroundLabel',
fontSize: 14,
marginRight: 72,
},
rolePanelList: {
backgroundColor: 'panelForeground',
marginTop: 8,
padding: 4,
maxHeight: 400,
},
rolePanelEntry: {
flexDirection: 'row',
justifyContent: 'space-between',
alignItems: 'center',
padding: 8,
},
rolePanelNameEntry: {
color: 'whiteText',
fontWeight: '600',
fontSize: 14,
},
rolePanelCountEntry: {
color: 'whiteText',
fontWeight: '600',
fontSize: 14,
marginRight: 72,
padding: 8,
},
buttonContainer: {
backgroundColor: 'panelForeground',
padding: 2,
},
createRoleButton: {
justifyContent: 'center',
alignItems: 'center',
margin: 10,
backgroundColor: 'purpleButton',
height: 48,
borderRadius: 10,
},
createRoleButtonText: {
color: 'whiteText',
fontSize: 16,
fontWeight: '500',
},
};
export default CommunityRolesScreen; export default CommunityRolesScreen;