[identity] Remove references to "devices" attr in users table
ClosedPublic
Actions

Authored by bartek on Jan 18 2024, 4:00 AM.

Details

Reviewers

varun
michal

Commits

rCOMMb8349ecd2e20: [identity] Remove references to "devices" attr in users table

Summary

Part of ENG-5842.
This diff removes almost all code that referenced "devices" attribute in users table. The code left is not nice, further refactors are done in subsequent diffs.

The only part left is adding devices to the list, which is done separately in D10698 (I had to reverse diff order to make CI pass)

Test Plan

Identity integration tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jan 18 2024, 4:00 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 18 2024, 4:00 AM

bartek added a child revision: D10700: [identity] Simplify some calls and conversions.Jan 18 2024, 4:01 AM

Harbormaster completed remote builds in B25887: Diff 35782.Jan 18 2024, 4:19 AM

Change diff order to make Commtest CI pass

Harbormaster completed remote builds in B25890: Diff 35785.Jan 18 2024, 5:29 AM

bartek removed a parent revision: D10698: [identity] Stop adding devices to users table.Jan 18 2024, 5:33 AM

bartek added a child revision: D10698: [identity] Stop adding devices to users table.

bartek removed a child revision: D10700: [identity] Simplify some calls and conversions.

bartek edited the summary of this revision. (Show Details)

bartek published this revision for review.Jan 18 2024, 8:07 AM

bartek added inline comments.

services/identity/src/database.rs
555–572 ↗	(On Diff #35785)	This intermediate function is removed in the next diff
655–660 ↗	(On Diff #35785)	This intermediate function is removed in the next diff
1155–1178 ↗	(On Diff #35785)	Previously, we were merging legacy and new device list attribute by attribute, now we no longer need that.