lib/reducers/keyserver-reducer.js
430	You want to check if `action.payload.keyserverIDs` includes `ashoatKeyserverID`. The logic is that this action has in `action.payload.keyserverIDs` ids of keyservers the user is disconnecting from. We want to remove them from the store, with the exception of Ashoat's keyserver, which has to be in the store at all times. So if Ashoat's keyserver is included in `action.payload.keyserverIDs`, we just want to clear some fields for it. For the record, `state.keyserverInfos` should always include and entry for `ashoatKeyserverID` (until we have real DMs)

This revision now requires changes to proceed.Jan 31 2024, 6:15 AM

address review

It would be great if you could also check if running this action with Ashoat's id in payload resets Ashoat's keyserver correctly - this is not included in keyserver-reducer.test.js

Also, what does thread-activity-reducer.test.js have to do with this?

This revision is now accepted and ready to land.Jan 31 2024, 7:37 AM

Harbormaster completed remote builds in B26329: Diff 36382.Jan 31 2024, 7:44 AM

implement tests

kamil edited the test plan for this revision. (Show Details)Jan 31 2024, 8:02 AM

inka accepted this revision.Jan 31 2024, 8:05 AM

This revision was landed with ongoing or failed builds.Jan 31 2024, 8:23 AM

Closed by commit rCOMMa1cfde03647c: [lib] refactor deleting keyserver account `keyserver-reducer` to ops (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa1cfde03647c: [lib] refactor deleting keyserver account `keyserver-reducer` to ops.

Harbormaster completed remote builds in B26333: Diff 36386.Jan 31 2024, 8:26 AM