with custom type WebsocketSink
ClosedPublic
Actions

Authored by will on Jan 31 2024, 2:17 PM.

Details

Reviewers

varun
bartek

Commits

rCOMM6091f1d7e967: [identity] [10/n] Replace usages of Arc<Mutex<SplitSink<WebSocketStream<Upgrad…

Summary

Utilizing a custom type, replaces Arc<Mutex<SplitSink<WebSocketStream<Upgraded>.

Depends on D10878

Test Plan

built with cargo

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Jan 31 2024, 2:17 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 31 2024, 2:17 PM

will retitled this revision from [identity] Replace usages of Arc<Mutex<SplitSink<WebSocketStream<Upgraded>, Message>>> with custom type WebsocketSink to [identity] [10/n] Replace usages of Arc<Mutex<SplitSink<WebSocketStream<Upgraded>, Message>>> with custom type WebsocketSink.Jan 31 2024, 2:22 PM

will edited the summary of this revision. (Show Details)

will added a parent revision: D10878: [lib] [9/n] Move ConnectionInitializationResponse and Heartbeat types out of lib tunnelbroker into shared websocket folder.

will mentioned this in D10847: [identity] [3/n] move websocket response functions to send.rs.

Harbormaster completed remote builds in B26384: Diff 36479.Jan 31 2024, 2:36 PM

will requested review of this revision.Jan 31 2024, 2:36 PM

varun accepted this revision.Jan 31 2024, 2:42 PM

This revision is now accepted and ready to land.Jan 31 2024, 2:42 PM

Closed by commit rCOMM6091f1d7e967: [identity] [10/n] Replace usages of Arc<Mutex<SplitSink<WebSocketStream<Upgrad… (authored by will). · Explain WhyJan 31 2024, 2:55 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM6091f1d7e967: [identity] [10/n] Replace usages of Arc<Mutex<SplitSink<WebSocketStream<Upgrad….

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

websockets/

send.rs

7 lines

Diff 36493

View Options

services/identity/src/websockets/send.rs

Show First 20 Lines • Show All 149 Lines • ▼ Show 20 Lines	tShape({
sourceMessageID: tID,		sourceMessageID: tID,
...threadRequestValidationShape,		...threadRequestValidationShape,
}),		}),
tShape({		tShape({
type: tNumEnum([		type: tNumEnum([
threadTypes.COMMUNITY_OPEN_SUBTHREAD,		threadTypes.COMMUNITY_OPEN_SUBTHREAD,
threadTypes.COMMUNITY_SECRET_SUBTHREAD,		threadTypes.COMMUNITY_SECRET_SUBTHREAD,
threadTypes.GENESIS_PERSONAL,		threadTypes.GENESIS_PERSONAL,
threadTypes.LOCAL,
threadTypes.COMMUNITY_ROOT,		threadTypes.COMMUNITY_ROOT,
threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT,		threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT,
threadTypes.COMMUNITY_OPEN_ANNOUNCEMENT_SUBTHREAD,		threadTypes.COMMUNITY_OPEN_ANNOUNCEMENT_SUBTHREAD,
threadTypes.COMMUNITY_SECRET_ANNOUNCEMENT_SUBTHREAD,		threadTypes.COMMUNITY_SECRET_ANNOUNCEMENT_SUBTHREAD,
]),		]),
...threadRequestValidationShape,		...threadRequestValidationShape,
}),		}),
]);		]);
▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines

[identity] [10/n] Replace usages of Arc<Mutex<SplitSink<WebSocketStream<Upgraded>, Message>>> with custom type WebsocketSinkClosedPublicActions