adding a password log in action that will be dispatched in the next diff
Depends on D10816
Details
Details
- Reviewers
ashoat inka tomek - Commits
- rCOMM805c1b14fde7: [lib] add identity password log in action
will be tested in next diff by actually dispatching the action
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/actions/user-actions.js | ||
|---|---|---|
| 434–438 ↗ | (On Diff #36137) | i'll rename this later to make it reusable for wallet login too. see this comment |
| lib/actions/user-actions.js | ||
|---|---|---|
| 434–438 ↗ | (On Diff #36137) | renamed tempIdentityLoginActionTypes |
| 440 ↗ | (On Diff #36137) | we use the verb form for other hooks like useIdentityRegister(), useClaimUsername(), etc. |
| 440 ↗ | (On Diff #36137) | I'm going to keep the verb form from now but can change it if you feel strongly. just don't think it makes sense given all the other hooks use the verb form, including the legacy useLogIn hook |
| lib/types/redux-types.js | ||
|---|---|---|
| 345–360 ↗ | (On Diff #36570) | I'm confused – why are these being deleted instead of renamed? |
| lib/types/redux-types.js | ||
|---|---|---|
| 345–360 ↗ | (On Diff #36570) | |
| lib/types/redux-types.js | ||
|---|---|---|
| 345–360 ↗ | (On Diff #36570) | actually this will take 2 seconds, so i'll just do it now |
Comment Actions
Ah, missed that. The type names don't match, so you'll need to rebase anyways to fix them... at this point, might as well move the types to this diff. Since this where you define the constants, it's easier to compare and notice discrepancies