Page MenuHomePhabricator
Differential D11020

[web] use identity wallet login in siwe-login-form
ClosedPublic
Actions

Authored by varun on Feb 9 2024, 10:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 3:52 PM
Unknown Object (File)
Oct 15 2024, 5:39 PM
Unknown Object (File)
Oct 15 2024, 5:39 PM
Unknown Object (File)
Oct 15 2024, 5:39 PM
Unknown Object (File)
Oct 15 2024, 5:38 PM
Unknown Object (File)
Oct 15 2024, 5:38 PM
Unknown Object (File)
Sep 20 2024, 6:33 PM
Unknown Object (File)
Sep 19 2024, 10:56 AM
View All 59 Files
Subscribers
None

Details

Reviewers
ashoat
inka
tomek
Commits
rCOMM507a3adde3c1: [web] use identity wallet login in siwe-login-form
Summary

If usingCommServicesAccessToken, call identity service wallet login RPC.

Depends on D11019

Test Plan

Confirmed that action succeeded in redux devtools, inspected payload and confirmed that the access token and user ID matched local DDB

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Feb 9 2024, 10:48 AM
Harbormaster completed remote builds in B26723: Diff 36949.Feb 9 2024, 11:02 AM
varun requested review of this revision.Feb 9 2024, 11:02 AM
varun added a child revision: D11021: [native] call setCommServicesAuthMetadata on identity registration and login.Feb 9 2024, 11:18 AM
ashoat requested changes to this revision.Feb 9 2024, 11:24 AM
ashoat added inline comments.
web/account/siwe-login-form.react.js
138 ↗(On Diff #36949)

You'll need to find a way to replicate this

This revision now requires changes to proceed.Feb 9 2024, 11:24 AM
varun added inline comments.Feb 15 2024, 8:42 PM
web/account/siwe-login-form.react.js
138 ↗(On Diff #36949)

now that we've separated wallet login and registration RPCs, calling login ensures that we don't register a new account

varun updated this revision to Diff 37291.Feb 15 2024, 8:42 PM

match existing error handling

Harbormaster completed remote builds in B26948: Diff 37291.Feb 15 2024, 9:05 PM
ashoat added a comment.Feb 16 2024, 7:25 AM

Are we planning a "fallback" mechanism here?

varun added a comment.Feb 22 2024, 5:43 PM
In D11020#320733, @ashoat wrote:

Are we planning a "fallback" mechanism here?

we have a new plan instead of a fallback mechanism including automated alerts, daily manual testing, and an opt-in mechanism for clients to inform us when there are issues

ashoat accepted this revision.Feb 22 2024, 7:44 PM
This revision is now accepted and ready to land.Feb 22 2024, 7:44 PM
Closed by commit rCOMM507a3adde3c1: [web] use identity wallet login in siwe-login-form (authored by varun). · Explain WhyFeb 22 2024, 8:17 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM507a3adde3c1: [web] use identity wallet login in siwe-login-form.

Revision Contents
Changeset List

PathSize
web/
account/
48 lines

Diff 37291

View Options

web/account/siwe-login-form.react.js

Loading...