- Move some types from CommCoreModuleSchema.js -> crypto-types.js
- Add validator for SignedPrekeys
- UserDevicesOlmInboundKeys type and validator
- Group types in identity-service-types.js
Details
Details
FLow
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/types/crypto-types.js | ||
|---|---|---|
| 25–28 ↗ | (On Diff #37323) | It might appear more convenient to have two fields, one for content and one for notif, each being an object with prekey and prekeySignature |
| lib/types/identity-service-types.js | ||
| 87–88 ↗ | (On Diff #37323) | Can these two be null at the same time? If not, then can we reflect that in the type? |
| lib/types/crypto-types.js | ||
|---|---|---|
| 25–28 ↗ | (On Diff #37323) | I am just moving this type - it will require changing C++ code which returns prekeys |
| lib/types/identity-service-types.js | ||
| 87–88 ↗ | (On Diff #37323) | This is based on InboundKeyInfoResponse - but there is some ongoing work to improve it (https://phab.comm.dev/D11108#inline-67556) |