Page MenuHomePhabricator
Differential D11192

[lib] introduce removeCommunityActionType
AcceptedPublic
Actions

Authored by ginsu on Feb 28 2024, 12:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 7, 9:39 PM
Unknown Object (File)
Sat, Mar 1, 8:54 AM
Unknown Object (File)
Feb 21 2025, 7:26 PM
Unknown Object (File)
Feb 21 2025, 7:26 PM
Unknown Object (File)
Feb 21 2025, 7:26 PM
Unknown Object (File)
Feb 6 2025, 10:18 AM
Unknown Object (File)
Jan 22 2025, 3:20 AM
Unknown Object (File)
Jan 16 2025, 8:10 PM
View All 77 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
kamil
Summary

This diff introduces the removeCommunityActionType and the logic for this action in the community reducer

Linear task: https://linear.app/comm/issue/ENG-6579/introduce-removing-a-community-from-the-community-store-action

Depends on D11167

Test Plan

Ran the following code + confirmed that the community was being removed

const fakeCommunityID = '256|84261';

const onPressRemoveCommunity = React.useCallback(() => {
  dispatch({
    type: removeCommunityActionType,
    payload: {
      id: fakeCommunityID,
    },
  });
}, [dispatch]);

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Feb 28 2024, 12:24 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 28 2024, 12:24 AM
ginsu edited the summary of this revision. (Show Details)Feb 28 2024, 12:26 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, kamil.
ginsu added a parent revision: D11167: [lib] populate community store on user login.
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 28 2024, 12:35 AM
Harbormaster failed remote builds in B27222: Diff 37681!
ginsu requested review of this revision.Feb 28 2024, 6:22 AM

will make sure ci passes before landing

kamil accepted this revision.Feb 29 2024, 6:39 AM
This revision is now accepted and ready to land.Feb 29 2024, 6:39 AM

Revision Contents
Changeset List

PathSize
lib/
actions/
3 lines
reducers/
18 lines
types/
4 lines
10 lines

Diff 37681

View Options

lib/actions/community-actions.js

// @flow // @flow
const updateCalendarCommunityFilter = 'UPDATE_CALENDAR_COMMUNITY_FILTER'; const updateCalendarCommunityFilter = 'UPDATE_CALENDAR_COMMUNITY_FILTER';
const clearCalendarCommunityFilter = 'CLEAR_CALENDAR_COMMUNITY_FILTER'; const clearCalendarCommunityFilter = 'CLEAR_CALENDAR_COMMUNITY_FILTER';
const updateChatCommunityFilter = 'UPDATE_CHAT_COMMUNITY_FILTER'; const updateChatCommunityFilter = 'UPDATE_CHAT_COMMUNITY_FILTER';
const clearChatCommunityFilter = 'CLEAR_CHAT_COMMUNITY_FILTER'; const clearChatCommunityFilter = 'CLEAR_CHAT_COMMUNITY_FILTER';
const addCommunityActionType = 'ADD_COMMUNITY'; const addCommunityActionType = 'ADD_COMMUNITY';
const removeCommunityActionType = 'REMOVE_COMMUNITY';
export { export {
updateCalendarCommunityFilter, updateCalendarCommunityFilter,
clearCalendarCommunityFilter, clearCalendarCommunityFilter,
updateChatCommunityFilter, updateChatCommunityFilter,
clearChatCommunityFilter, clearChatCommunityFilter,
addCommunityActionType, addCommunityActionType,
removeCommunityActionType,
}; };
View Options

lib/reducers/community-reducer.js

// @flow // @flow
import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js'; import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js';
import { addCommunityActionType } from '../actions/community-actions.js'; import {
addCommunityActionType,
removeCommunityActionType,
} from '../actions/community-actions.js';
import { siweAuthActionTypes } from '../actions/siwe-actions.js'; import { siweAuthActionTypes } from '../actions/siwe-actions.js';
import { import {
logInActionTypes, logInActionTypes,
keyserverRegisterActionTypes, keyserverRegisterActionTypes,
} from '../actions/user-actions.js'; } from '../actions/user-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
type RemoveCommunitiesOperation,
type RemoveAllCommunitiesOperation, type RemoveAllCommunitiesOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { import type {
CommunityStore, CommunityStore,
CommunityInfo, CommunityInfo,
} from '../types/community-types.js'; } from '../types/community-types.js';
import { defaultEnabledApps } from '../types/enabled-apps.js'; import { defaultEnabledApps } from '../types/enabled-apps.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
▲ Show 20 Lines • Show All 55 Lines • ▼ Show 20 Lines const replaceOperation: ReplaceCommunityOperation = {
}, },
}, },
}; };
return { return {
communityStore: processStoreOps(state, [replaceOperation]), communityStore: processStoreOps(state, [replaceOperation]),
communityStoreOperations: [replaceOperation], communityStoreOperations: [replaceOperation],
}; };
} else if (action.type === removeCommunityActionType) {
const removeOperation: RemoveCommunitiesOperation = {
type: 'remove_communities',
payload: {
ids: [action.payload.id],
},
};
return {
communityStore: processStoreOps(state, [removeOperation]),
communityStoreOperations: [removeOperation],
};
} else if (action.type === setClientDBStoreActionType) { } else if (action.type === setClientDBStoreActionType) {
const newCommunityInfo = action.payload.communityInfos; const newCommunityInfo = action.payload.communityInfos;
if (!newCommunityInfo) { if (!newCommunityInfo) {
return { return {
communityStore: state, communityStore: state,
communityStoreOperations: [], communityStoreOperations: [],
}; };
Show All 18 Lines
View Options

lib/types/community-types.js

Show All 10 Lines
export type CommunityStore = { export type CommunityStore = {
+communityInfos: CommunityInfos, +communityInfos: CommunityInfos,
}; };
export type AddCommunityPayload = { export type AddCommunityPayload = {
+id: string, +id: string,
+newCommunityInfo: CommunityInfo, +newCommunityInfo: CommunityInfo,
}; };
export type RemoveCommunityPayload = {
+id: string,
};
View Options

lib/types/redux-types.js

Loading...