Page MenuHomePhabricator

[lib] introduce removeCommunityActionType
AcceptedPublic

Authored by ginsu on Feb 28 2024, 12:24 AM.
Tags
None
Referenced Files
F3391314: D11192.diff
Sat, Nov 30, 3:21 AM
Unknown Object (File)
Wed, Nov 27, 2:27 AM
Unknown Object (File)
Sun, Nov 24, 8:46 AM
Unknown Object (File)
Thu, Nov 21, 11:34 PM
Unknown Object (File)
Wed, Nov 6, 2:29 PM
Unknown Object (File)
Oct 21 2024, 1:15 PM
Unknown Object (File)
Oct 16 2024, 1:42 AM
Unknown Object (File)
Oct 14 2024, 6:28 PM
Subscribers

Details

Reviewers
atul
inka
kamil
Summary

This diff introduces the removeCommunityActionType and the logic for this action in the community reducer

Linear task: https://linear.app/comm/issue/ENG-6579/introduce-removing-a-community-from-the-community-store-action

Depends on D11167

Test Plan

Ran the following code + confirmed that the community was being removed

const fakeCommunityID = '256|84261';

const onPressRemoveCommunity = React.useCallback(() => {
  dispatch({
    type: removeCommunityActionType,
    payload: {
      id: fakeCommunityID,
    },
  });
}, [dispatch]);

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, kamil.
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 28 2024, 12:35 AM
Harbormaster failed remote builds in B27222: Diff 37681!
ginsu requested review of this revision.Feb 28 2024, 6:22 AM

will make sure ci passes before landing

This revision is now accepted and ready to land.Feb 29 2024, 6:39 AM