Page MenuHomePhabricator
Differential D11436

[lib] Add "Legacy" to types in `update-relationship`
ClosedPublic
Actions

Authored by atul on Mar 28 2024, 7:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 12:32 AM
Unknown Object (File)
Tue, Apr 8, 9:06 PM
Unknown Object (File)
Tue, Apr 8, 9:01 PM
Unknown Object (File)
Tue, Apr 8, 8:53 PM
Unknown Object (File)
Sun, Apr 6, 8:58 AM
Unknown Object (File)
Wed, Apr 2, 9:27 AM
Unknown Object (File)
Wed, Apr 2, 6:42 AM
Unknown Object (File)
Tue, Apr 1, 9:12 PM
View All 78 Files
Subscribers
ashoat

Details

Reviewers
varun
tomek
ginsu
will
Commits
rCOMM400d44d483a7: [lib] Add "Legacy" to types in `update-relationship`
Summary

Based on the following commits from hackathon branch: https://github.com/CommE2E/comm/commit/9632b8c4641cfe3d1724a94da56ffdcfc226d647#diff-f60296b8773612dd2bd84b6b259c08df2ef75250493fadc5d745aa5de47b3180, https://github.com/CommE2E/comm/commit/42f28702abce0769aa1aac0417c5006faebce254

Test Plan

Used IDE Refactor -> Rename feature.

Flow/ESLint/etc.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
4 lines
messages/
50 lines
types/
24 lines
messages/
legacy-update-relationship.js
update-relationship.js
12 lines
utils/
21 lines

Diff 38442

View Options

lib/shared/message-utils.test.js

Show All 12 Lines
import { import {
createAsyncMigrate, createAsyncMigrate,
type StorageMigrationFunction, type StorageMigrationFunction,
} from 'lib/shared/create-async-migrate.js'; } from 'lib/shared/create-async-migrate.js';
import type { import type {
KeyserverInfo, KeyserverInfo,
KeyserverStore, KeyserverStore,
} from 'lib/types/keyserver-types.js'; } from 'lib/types/keyserver-types.js';
import { cookieTypes } from 'lib/types/session-types.js';
import { import {
defaultConnectionInfo, defaultConnectionInfo,
type ConnectionInfo, type ConnectionInfo,
} from 'lib/types/socket-types.js'; } from 'lib/types/socket-types.js';
import { parseCookies } from 'lib/utils/cookie-utils.js';
import { isDev } from 'lib/utils/dev-utils.js'; import { isDev } from 'lib/utils/dev-utils.js';
import { import {
generateIDSchemaMigrationOpsForDrafts, generateIDSchemaMigrationOpsForDrafts,
convertDraftStoreToNewIDSchema, convertDraftStoreToNewIDSchema,
} from 'lib/utils/migration-utils.js'; } from 'lib/utils/migration-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import commReduxStorageEngine from './comm-redux-storage-engine.js'; import commReduxStorageEngine from './comm-redux-storage-engine.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines [5]: async state => {
await databaseModule.schedule({ await databaseModule.schedule({
type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS, type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,
storeOperations: { draftStoreOperations }, storeOperations: { draftStoreOperations },
}); });
return state; return state;
}, },
[6]: async (state: AppState): Promise<AppState> => {
const params = parseCookies(document.cookie);
let cookie = null;
if (params[cookieTypes.USER]) {
cookie = `${cookieTypes.USER}=${params[cookieTypes.USER]}`;
} else if (params[cookieTypes.ANONYMOUS]) {
cookie = `${cookieTypes.ANONYMOUS}=${params[cookieTypes.ANONYMOUS]}`;
}
return {
...state,
keyserverStore: {
...state.keyserverStore,
keyserverInfos: {
...state.keyserverStore.keyserverInfos,
[ashoatKeyserverID]: {
...state.keyserverStore.keyserverInfos[ashoatKeyserverID],
cookie,
},
},
},
};
},
}; };
const persistWhitelist = [ const persistWhitelist = [
'enabledApps', 'enabledApps',
'deviceID', 'deviceID',
'cryptoStore', 'cryptoStore',
'notifPermissionAlertInfo', 'notifPermissionAlertInfo',
'commServicesAccessToken', 'commServicesAccessToken',
▲ Show 20 Lines • Show All 96 Lines • ▼ Show 20 Linesconst persistConfig: PersistConfig = {
whitelist: isSQLiteSupported() whitelist: isSQLiteSupported()
? persistWhitelist ? persistWhitelist
: [...persistWhitelist, 'draftStore'], : [...persistWhitelist, 'draftStore'],
migrate: (createAsyncMigrate( migrate: (createAsyncMigrate(
migrations, migrations,
{ debug: isDev }, { debug: isDev },
migrateStorageToSQLite, migrateStorageToSQLite,
): any), ): any),
version: 5, version: 6,
transforms: [keyserverStoreTransform], transforms: [keyserverStoreTransform],
}; };
export { persistConfig }; export { persistConfig };
View Options

lib/shared/messages/update-relationship-message-spec.js

Show All 12 Lines
import { import {
createAsyncMigrate, createAsyncMigrate,
type StorageMigrationFunction, type StorageMigrationFunction,
} from 'lib/shared/create-async-migrate.js'; } from 'lib/shared/create-async-migrate.js';
import type { import type {
KeyserverInfo, KeyserverInfo,
KeyserverStore, KeyserverStore,
} from 'lib/types/keyserver-types.js'; } from 'lib/types/keyserver-types.js';
import { cookieTypes } from 'lib/types/session-types.js';
import { import {
defaultConnectionInfo, defaultConnectionInfo,
type ConnectionInfo, type ConnectionInfo,
} from 'lib/types/socket-types.js'; } from 'lib/types/socket-types.js';
import { parseCookies } from 'lib/utils/cookie-utils.js';
import { isDev } from 'lib/utils/dev-utils.js'; import { isDev } from 'lib/utils/dev-utils.js';
import { import {
generateIDSchemaMigrationOpsForDrafts, generateIDSchemaMigrationOpsForDrafts,
convertDraftStoreToNewIDSchema, convertDraftStoreToNewIDSchema,
} from 'lib/utils/migration-utils.js'; } from 'lib/utils/migration-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import commReduxStorageEngine from './comm-redux-storage-engine.js'; import commReduxStorageEngine from './comm-redux-storage-engine.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines [5]: async state => {
await databaseModule.schedule({ await databaseModule.schedule({
type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS, type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,
storeOperations: { draftStoreOperations }, storeOperations: { draftStoreOperations },
}); });
return state; return state;
}, },
[6]: async (state: AppState): Promise<AppState> => {
const params = parseCookies(document.cookie);
let cookie = null;
if (params[cookieTypes.USER]) {
cookie = `${cookieTypes.USER}=${params[cookieTypes.USER]}`;
} else if (params[cookieTypes.ANONYMOUS]) {
cookie = `${cookieTypes.ANONYMOUS}=${params[cookieTypes.ANONYMOUS]}`;
}
return {
...state,
keyserverStore: {
...state.keyserverStore,
keyserverInfos: {
...state.keyserverStore.keyserverInfos,
[ashoatKeyserverID]: {
...state.keyserverStore.keyserverInfos[ashoatKeyserverID],
cookie,
},
},
},
};
},
}; };
const persistWhitelist = [ const persistWhitelist = [
'enabledApps', 'enabledApps',
'deviceID', 'deviceID',
'cryptoStore', 'cryptoStore',
'notifPermissionAlertInfo', 'notifPermissionAlertInfo',
'commServicesAccessToken', 'commServicesAccessToken',
▲ Show 20 Lines • Show All 96 Lines • ▼ Show 20 Linesconst persistConfig: PersistConfig = {
whitelist: isSQLiteSupported() whitelist: isSQLiteSupported()
? persistWhitelist ? persistWhitelist
: [...persistWhitelist, 'draftStore'], : [...persistWhitelist, 'draftStore'],
migrate: (createAsyncMigrate( migrate: (createAsyncMigrate(
migrations, migrations,
{ debug: isDev }, { debug: isDev },
migrateStorageToSQLite, migrateStorageToSQLite,
): any), ): any),
version: 5, version: 6,
transforms: [keyserverStoreTransform], transforms: [keyserverStoreTransform],
}; };
export { persistConfig }; export { persistConfig };
View Options

lib/types/message-types.js

Show All 12 Lines
import { import {
createAsyncMigrate, createAsyncMigrate,
type StorageMigrationFunction, type StorageMigrationFunction,
} from 'lib/shared/create-async-migrate.js'; } from 'lib/shared/create-async-migrate.js';
import type { import type {
KeyserverInfo, KeyserverInfo,
KeyserverStore, KeyserverStore,
} from 'lib/types/keyserver-types.js'; } from 'lib/types/keyserver-types.js';
import { cookieTypes } from 'lib/types/session-types.js';
import { import {
defaultConnectionInfo, defaultConnectionInfo,
type ConnectionInfo, type ConnectionInfo,
} from 'lib/types/socket-types.js'; } from 'lib/types/socket-types.js';
import { parseCookies } from 'lib/utils/cookie-utils.js';
import { isDev } from 'lib/utils/dev-utils.js'; import { isDev } from 'lib/utils/dev-utils.js';
import { import {
generateIDSchemaMigrationOpsForDrafts, generateIDSchemaMigrationOpsForDrafts,
convertDraftStoreToNewIDSchema, convertDraftStoreToNewIDSchema,
} from 'lib/utils/migration-utils.js'; } from 'lib/utils/migration-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import commReduxStorageEngine from './comm-redux-storage-engine.js'; import commReduxStorageEngine from './comm-redux-storage-engine.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines [5]: async state => {
await databaseModule.schedule({ await databaseModule.schedule({
type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS, type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,
storeOperations: { draftStoreOperations }, storeOperations: { draftStoreOperations },
}); });
return state; return state;
}, },
[6]: async (state: AppState): Promise<AppState> => {
const params = parseCookies(document.cookie);
let cookie = null;
if (params[cookieTypes.USER]) {
cookie = `${cookieTypes.USER}=${params[cookieTypes.USER]}`;
} else if (params[cookieTypes.ANONYMOUS]) {
cookie = `${cookieTypes.ANONYMOUS}=${params[cookieTypes.ANONYMOUS]}`;
}
return {
...state,
keyserverStore: {
...state.keyserverStore,
keyserverInfos: {
...state.keyserverStore.keyserverInfos,
[ashoatKeyserverID]: {
...state.keyserverStore.keyserverInfos[ashoatKeyserverID],
cookie,
},
},
},
};
},
}; };
const persistWhitelist = [ const persistWhitelist = [
'enabledApps', 'enabledApps',
'deviceID', 'deviceID',
'cryptoStore', 'cryptoStore',
'notifPermissionAlertInfo', 'notifPermissionAlertInfo',
'commServicesAccessToken', 'commServicesAccessToken',
▲ Show 20 Lines • Show All 96 Lines • ▼ Show 20 Linesconst persistConfig: PersistConfig = {
whitelist: isSQLiteSupported() whitelist: isSQLiteSupported()
? persistWhitelist ? persistWhitelist
: [...persistWhitelist, 'draftStore'], : [...persistWhitelist, 'draftStore'],
migrate: (createAsyncMigrate( migrate: (createAsyncMigrate(
migrations, migrations,
{ debug: isDev }, { debug: isDev },
migrateStorageToSQLite, migrateStorageToSQLite,
): any), ): any),
version: 5, version: 6,
transforms: [keyserverStoreTransform], transforms: [keyserverStoreTransform],
}; };
export { persistConfig }; export { persistConfig };
View Options

lib/types/messages/legacy-update-relationship.js

Show All 12 Lines
import { import {
createAsyncMigrate, createAsyncMigrate,
type StorageMigrationFunction, type StorageMigrationFunction,
} from 'lib/shared/create-async-migrate.js'; } from 'lib/shared/create-async-migrate.js';
import type { import type {
KeyserverInfo, KeyserverInfo,
KeyserverStore, KeyserverStore,
} from 'lib/types/keyserver-types.js'; } from 'lib/types/keyserver-types.js';
import { cookieTypes } from 'lib/types/session-types.js';
import { import {
defaultConnectionInfo, defaultConnectionInfo,
type ConnectionInfo, type ConnectionInfo,
} from 'lib/types/socket-types.js'; } from 'lib/types/socket-types.js';
import { parseCookies } from 'lib/utils/cookie-utils.js';
import { isDev } from 'lib/utils/dev-utils.js'; import { isDev } from 'lib/utils/dev-utils.js';
import { import {
generateIDSchemaMigrationOpsForDrafts, generateIDSchemaMigrationOpsForDrafts,
convertDraftStoreToNewIDSchema, convertDraftStoreToNewIDSchema,
} from 'lib/utils/migration-utils.js'; } from 'lib/utils/migration-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import commReduxStorageEngine from './comm-redux-storage-engine.js'; import commReduxStorageEngine from './comm-redux-storage-engine.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines [5]: async state => {
await databaseModule.schedule({ await databaseModule.schedule({
type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS, type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,
storeOperations: { draftStoreOperations }, storeOperations: { draftStoreOperations },
}); });
return state; return state;
}, },
[6]: async (state: AppState): Promise<AppState> => {
const params = parseCookies(document.cookie);
let cookie = null;
if (params[cookieTypes.USER]) {
cookie = `${cookieTypes.USER}=${params[cookieTypes.USER]}`;
} else if (params[cookieTypes.ANONYMOUS]) {
cookie = `${cookieTypes.ANONYMOUS}=${params[cookieTypes.ANONYMOUS]}`;
}
return {
...state,
keyserverStore: {
...state.keyserverStore,
keyserverInfos: {
...state.keyserverStore.keyserverInfos,
[ashoatKeyserverID]: {
...state.keyserverStore.keyserverInfos[ashoatKeyserverID],
cookie,
},
},
},
};
},
}; };
const persistWhitelist = [ const persistWhitelist = [
'enabledApps', 'enabledApps',
'deviceID', 'deviceID',
'cryptoStore', 'cryptoStore',
'notifPermissionAlertInfo', 'notifPermissionAlertInfo',
'commServicesAccessToken', 'commServicesAccessToken',
▲ Show 20 Lines • Show All 96 Lines • ▼ Show 20 Linesconst persistConfig: PersistConfig = {
whitelist: isSQLiteSupported() whitelist: isSQLiteSupported()
? persistWhitelist ? persistWhitelist
: [...persistWhitelist, 'draftStore'], : [...persistWhitelist, 'draftStore'],
migrate: (createAsyncMigrate( migrate: (createAsyncMigrate(
migrations, migrations,
{ debug: isDev }, { debug: isDev },
migrateStorageToSQLite, migrateStorageToSQLite,
): any), ): any),
version: 5, version: 6,
transforms: [keyserverStoreTransform], transforms: [keyserverStoreTransform],
}; };
export { persistConfig }; export { persistConfig };
View Options

lib/types/messages/update-relationship.js

Show All 12 Lines
import { import {
createAsyncMigrate, createAsyncMigrate,
type StorageMigrationFunction, type StorageMigrationFunction,
} from 'lib/shared/create-async-migrate.js'; } from 'lib/shared/create-async-migrate.js';
import type { import type {
KeyserverInfo, KeyserverInfo,
KeyserverStore, KeyserverStore,
} from 'lib/types/keyserver-types.js'; } from 'lib/types/keyserver-types.js';
import { cookieTypes } from 'lib/types/session-types.js';
import { import {
defaultConnectionInfo, defaultConnectionInfo,
type ConnectionInfo, type ConnectionInfo,
} from 'lib/types/socket-types.js'; } from 'lib/types/socket-types.js';
import { parseCookies } from 'lib/utils/cookie-utils.js';
import { isDev } from 'lib/utils/dev-utils.js'; import { isDev } from 'lib/utils/dev-utils.js';
import { import {
generateIDSchemaMigrationOpsForDrafts, generateIDSchemaMigrationOpsForDrafts,
convertDraftStoreToNewIDSchema, convertDraftStoreToNewIDSchema,
} from 'lib/utils/migration-utils.js'; } from 'lib/utils/migration-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import commReduxStorageEngine from './comm-redux-storage-engine.js'; import commReduxStorageEngine from './comm-redux-storage-engine.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines [5]: async state => {
await databaseModule.schedule({ await databaseModule.schedule({
type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS, type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,
storeOperations: { draftStoreOperations }, storeOperations: { draftStoreOperations },
}); });
return state; return state;
}, },
[6]: async (state: AppState): Promise<AppState> => {
const params = parseCookies(document.cookie);
let cookie = null;
if (params[cookieTypes.USER]) {
cookie = `${cookieTypes.USER}=${params[cookieTypes.USER]}`;
} else if (params[cookieTypes.ANONYMOUS]) {
cookie = `${cookieTypes.ANONYMOUS}=${params[cookieTypes.ANONYMOUS]}`;
}
return {
...state,
keyserverStore: {
...state.keyserverStore,
keyserverInfos: {
...state.keyserverStore.keyserverInfos,
[ashoatKeyserverID]: {
...state.keyserverStore.keyserverInfos[ashoatKeyserverID],
cookie,
},
},
},
};
},
}; };
const persistWhitelist = [ const persistWhitelist = [
'enabledApps', 'enabledApps',
'deviceID', 'deviceID',
'cryptoStore', 'cryptoStore',
'notifPermissionAlertInfo', 'notifPermissionAlertInfo',
'commServicesAccessToken', 'commServicesAccessToken',
▲ Show 20 Lines • Show All 96 Lines • ▼ Show 20 Linesconst persistConfig: PersistConfig = {
whitelist: isSQLiteSupported() whitelist: isSQLiteSupported()
? persistWhitelist ? persistWhitelist
: [...persistWhitelist, 'draftStore'], : [...persistWhitelist, 'draftStore'],
migrate: (createAsyncMigrate( migrate: (createAsyncMigrate(
migrations, migrations,
{ debug: isDev }, { debug: isDev },
migrateStorageToSQLite, migrateStorageToSQLite,
): any), ): any),
version: 5, version: 6,
transforms: [keyserverStoreTransform], transforms: [keyserverStoreTransform],
}; };
export { persistConfig }; export { persistConfig };
View Options

lib/utils/message-ops-utils.test.js

Show All 12 Lines
import { import {
createAsyncMigrate, createAsyncMigrate,
type StorageMigrationFunction, type StorageMigrationFunction,
} from 'lib/shared/create-async-migrate.js'; } from 'lib/shared/create-async-migrate.js';
import type { import type {
KeyserverInfo, KeyserverInfo,
KeyserverStore, KeyserverStore,
} from 'lib/types/keyserver-types.js'; } from 'lib/types/keyserver-types.js';
import { cookieTypes } from 'lib/types/session-types.js';
import { import {
defaultConnectionInfo, defaultConnectionInfo,
type ConnectionInfo, type ConnectionInfo,
} from 'lib/types/socket-types.js'; } from 'lib/types/socket-types.js';
import { parseCookies } from 'lib/utils/cookie-utils.js';
import { isDev } from 'lib/utils/dev-utils.js'; import { isDev } from 'lib/utils/dev-utils.js';
import { import {
generateIDSchemaMigrationOpsForDrafts, generateIDSchemaMigrationOpsForDrafts,
convertDraftStoreToNewIDSchema, convertDraftStoreToNewIDSchema,
} from 'lib/utils/migration-utils.js'; } from 'lib/utils/migration-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import commReduxStorageEngine from './comm-redux-storage-engine.js'; import commReduxStorageEngine from './comm-redux-storage-engine.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines [5]: async state => {
await databaseModule.schedule({ await databaseModule.schedule({
type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS, type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,
storeOperations: { draftStoreOperations }, storeOperations: { draftStoreOperations },
}); });
return state; return state;
}, },
[6]: async (state: AppState): Promise<AppState> => {
const params = parseCookies(document.cookie);
let cookie = null;
if (params[cookieTypes.USER]) {
cookie = `${cookieTypes.USER}=${params[cookieTypes.USER]}`;
} else if (params[cookieTypes.ANONYMOUS]) {
cookie = `${cookieTypes.ANONYMOUS}=${params[cookieTypes.ANONYMOUS]}`;
}
return {
...state,
keyserverStore: {
...state.keyserverStore,
keyserverInfos: {
...state.keyserverStore.keyserverInfos,
[ashoatKeyserverID]: {
...state.keyserverStore.keyserverInfos[ashoatKeyserverID],
cookie,
},
},
},
};
},
}; };
const persistWhitelist = [ const persistWhitelist = [
'enabledApps', 'enabledApps',
'deviceID', 'deviceID',
'cryptoStore', 'cryptoStore',
'notifPermissionAlertInfo', 'notifPermissionAlertInfo',
'commServicesAccessToken', 'commServicesAccessToken',
▲ Show 20 Lines • Show All 96 Lines • ▼ Show 20 Linesconst persistConfig: PersistConfig = {
whitelist: isSQLiteSupported() whitelist: isSQLiteSupported()
? persistWhitelist ? persistWhitelist
: [...persistWhitelist, 'draftStore'], : [...persistWhitelist, 'draftStore'],
migrate: (createAsyncMigrate( migrate: (createAsyncMigrate(
migrations, migrations,
{ debug: isDev }, { debug: isDev },
migrateStorageToSQLite, migrateStorageToSQLite,
): any), ): any),
version: 5, version: 6,
transforms: [keyserverStoreTransform], transforms: [keyserverStoreTransform],
}; };
export { persistConfig }; export { persistConfig };