Details

Reviewers

kamil
inka
will

Commits

rCOMMa6d8818e3171: [lib] Create a redux store where ops will be stored

Summary

Create the store. By default, it should contain an empty array.

https://linear.app/comm/issue/ENG-7096/add-a-new-field-in-redux-where-ops-are-stored

Test Plan

Inspect Redux on web and native and check if the store is present. Also close and reopen the app to make sure that there are no inconsistencies.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Mar 6 2024, 9:54 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 6 2024, 9:54 AM

Harbormaster completed remote builds in B27364: Diff 37895.Mar 6 2024, 10:51 AM

tomek requested review of this revision.Mar 6 2024, 10:51 AM

Can you explain why we don't want to persist ops? Wouldn't it be a problem if redux store got updated, but the app was closed before ops had the time to update the db?

lib/types/db-ops-types.js
6 ↗	(On Diff #37895)	What is this used for?
12 ↗	(On Diff #37895)	What is this used for?

In D11259#325290, @inka wrote:

Can you explain why we don't want to persist ops? Wouldn't it be a problem if redux store got updated, but the app was closed before ops had the time to update the db?

In the current design the flow should be like this:

Receive message
Decrypt
Processing in redux and database
Confirm

If we want to persist this, we could end up in a scenario where we open the app, and we have:

Processing in redux and database
Confirm

This requires implementing some additional things like remembering messageIDs, confirming not from the socket level but from the component responsible for processing etc.. With the current approach we will just start the flow again, it could be improved in the future but I think for now it might not be worth it.

tomek added inline comments.Mar 7 2024, 7:59 AM

lib/types/db-ops-types.js
6 ↗	(On Diff #37895)	We need a mapping between actions and ops - https://linear.app/comm/issue/ENG-7094/introduce-a-mapping-between-actions-and-ops. The plan is for each action that we want to track, to introduce an ID which then can be used when an ops processing finishes.
12 ↗	(On Diff #37895)	If an action doesn't generate ops we can immediately report its completion to the caller. This array allows us to do that because we don't need to wait for other ops to complete.