Page MenuHomePhabricator
Differential D11560

[native] implement connect farcaster bottom sheet ui
ClosedPublic
Actions

Authored by ginsu on Apr 4 2024, 12:03 PM.
Tags
None
Referenced Files
F3391829: D11560.id38789.diff
Sat, Nov 30, 6:13 AM
F3391470: D11560.diff
Sat, Nov 30, 4:09 AM
Unknown Object (File)
Wed, Nov 27, 2:45 AM
Unknown Object (File)
Wed, Nov 27, 2:33 AM
Unknown Object (File)
Tue, Nov 26, 7:27 AM
Unknown Object (File)
Wed, Nov 13, 3:53 AM
Unknown Object (File)
Wed, Nov 13, 3:53 AM
Unknown Object (File)
Wed, Nov 13, 3:53 AM
View All 53 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM9a7c9bac9bb4: [native] implement connect farcaster bottom sheet ui
Summary

This diff introduces the connect farcaster bottom sheet ui

Please note that the focus of this diff was to introduce the UI. Subsequent diffs will polish/finish up the connect farcaster bottom sheet on successfully connect functionality, fix the snap points, etc.

Linear task: https://linear.app/comm/issue/ENG-7519/implement-ui-for-connectfarcasterbottomsheet

Depends on D11559

Test Plan

Please see screenshots below

Screenshot 2024-04-04 at 1.35.26 PM.png (1×946 px, 607 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 4 2024, 12:03 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 4 2024, 12:03 PM
ginsu edited the summary of this revision. (Show Details)Apr 4 2024, 12:06 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11559: [native] introduce barebones connect farcaster bottom sheet to root navigator.
ginsu attached a referenced file: F1466853: Screenshot 2024-04-04 at 1.35.26 PM.png. (Show Details)
ginsu added a child revision: D11561: [native] calculate snap points for connect farcaster bottom sheet.Apr 4 2024, 12:19 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 4 2024, 12:21 PM
Harbormaster failed remote builds in B27987: Diff 38789!
ginsu requested review of this revision.Apr 4 2024, 12:22 PM

will make sure ci passes before landing

atul accepted this revision.Apr 4 2024, 1:12 PM
atul added inline comments.
native/components/connect-farcaster-bottom-sheet.react.js
42–58

Wouldn't hurt to do some memoization here

This revision is now accepted and ready to land.Apr 4 2024, 1:12 PM
ginsu updated this revision to Diff 38818.Apr 4 2024, 7:24 PM

address comments + rebase before landing

Harbormaster completed remote builds in B28007: Diff 38818.Apr 4 2024, 7:40 PM
Closed by commit rCOMM9a7c9bac9bb4: [native] implement connect farcaster bottom sheet ui (authored by ginsu). · Explain WhyApr 4 2024, 8:06 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM9a7c9bac9bb4: [native] implement connect farcaster bottom sheet ui.

Revision Contents
Changeset List

PathSize
native/
components/
46 lines

Diff 38789

View Options

native/components/connect-farcaster-bottom-sheet.react.js

Loading...