Introduces the aux user store reducer and fid setter action type
Depends on D11511
Details
Details
Ran the following code
const onPressSave = React.useCallback(async () => {
dispatch({
type: setFarcasterFriendsFIDActionType,
payload: {
farcasterUsers: [
{
userID: 'dispatch_test_userID_1',
username: 'dispatch_test_username_1',
farcasterID: 'dispatch_test_farcasterID_1',
},
],
},
});
dispatch({
type: setFarcasterFriendsFIDActionType,
payload: {
farcasterUsers: [
{
userID: 'dispatch_test_userID_2',
username: 'dispatch_test_username_2',
farcasterID: 'dispatch_test_farcasterID_3',
},
],
},
});
dispatch({
type: setFarcasterFriendsFIDActionType,
payload: {
farcasterUsers: [
{
userID: 'dispatch_test_userID_1',
username: 'dispatch_test_username_1',
farcasterID: 'dispatch_test_farcasterID_update',
},
],
},
});
}, [dispatch]);
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/reducers/aux-user-reducer.js | ||
|---|---|---|
| 23 ↗ | (On Diff #38683) | You can use forEach instead of map. Personally, I'd probably opt for a for-of loop |
Comment Actions
Overall looks good, just a few comments inline. Going to resign as reviewer so other reviewers can also take a look too
| lib/reducers/aux-user-reducer.js | ||
|---|---|---|
| 23 ↗ | (On Diff #38683) | Also .map() is used when we want to creates a new array, which it looks like we don't want to do here |
| lib/reducers/aux-user-reducer.test.js | ||
| 9 ↗ | (On Diff #38683) | Nit: this description is a bit misleading+confusing imo I would say something like "should update aux user store with farcaster data for a user" or something like that |