Page MenuHomePhabricator
Differential D11559

[native] introduce barebones connect farcaster bottom sheet to root navigator
ClosedPublic
Actions

Authored by ginsu on Apr 4 2024, 11:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 1:37 AM
Unknown Object (File)
Sun, Nov 3, 8:22 AM
Unknown Object (File)
Oct 12 2024, 8:50 PM
Unknown Object (File)
Oct 12 2024, 8:50 PM
Unknown Object (File)
Oct 12 2024, 8:50 PM
Unknown Object (File)
Oct 12 2024, 8:50 PM
Unknown Object (File)
Oct 12 2024, 8:49 PM
Unknown Object (File)
Sep 18 2024, 7:04 AM
View All 45 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMc813111a7acd: [native] introduce barebones connect farcaster bottom sheet to root navigator
Summary

This diff introduces the barebones connect farcaster bottom sheet component as well as all the necessary logic needed to route to this bottom sheet screen. Subsquent diffs will handle fully introdcuing the UI and all the other functionality needed for this bottom sheet

Linear tasks:https://linear.app/comm/issue/ENG-7521/introduce-connectfarcasterbottomsheetto-the-root-navigator + https://linear.app/comm/issue/ENG-7522/add-connectfarcasterbottomsheetto-root-param-list-bottom-sheet-param

Test Plan

Confirmed that I was able to get to this barebones bottom sheet

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 4 2024, 11:58 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 4 2024, 11:58 AM
ginsu edited the summary of this revision. (Show Details)Apr 4 2024, 12:01 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a child revision: D11560: [native] implement connect farcaster bottom sheet ui.Apr 4 2024, 12:06 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 4 2024, 12:16 PM
Harbormaster failed remote builds in B27986: Diff 38788!
ginsu requested review of this revision.Apr 4 2024, 12:22 PM

will make sure ci passes before landing

atul accepted this revision.Apr 4 2024, 1:10 PM
This revision is now accepted and ready to land.Apr 4 2024, 1:10 PM
ginsu updated this revision to Diff 38817.Apr 4 2024, 7:22 PM
ginsu edited the summary of this revision. (Show Details)

rebase before landing

Harbormaster completed remote builds in B28006: Diff 38817.Apr 4 2024, 7:38 PM
Closed by commit rCOMMc813111a7acd: [native] introduce barebones connect farcaster bottom sheet to root navigator (authored by ginsu). · Explain WhyApr 4 2024, 8:06 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMc813111a7acd: [native] introduce barebones connect farcaster bottom sheet to root navigator.

Revision Contents
Changeset List

PathSize
native/
components/
28 lines
navigation/
7 lines
3 lines

Diff 38817

View Options

native/components/connect-farcaster-bottom-sheet.react.js

Loading...
View Options

native/navigation/root-navigator.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...