Page MenuHomePhabricator
Differential D11644

Extract shareable logic from CreateSIWEBackupMessage component
ClosedPublic
Actions

Authored by marcin on Apr 12 2024, 5:23 AM.
Tags
None
Referenced Files
F3334562: D11644.diff
Thu, Nov 21, 7:02 AM
Unknown Object (File)
Fri, Nov 8, 7:04 AM
Unknown Object (File)
Wed, Nov 6, 9:21 PM
Unknown Object (File)
Sun, Nov 3, 5:56 AM
Unknown Object (File)
Oct 13 2024, 6:52 PM
Unknown Object (File)
Oct 12 2024, 5:09 PM
Unknown Object (File)
Oct 12 2024, 5:09 PM
Unknown Object (File)
Oct 12 2024, 5:09 PM
View All 83 Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
inka
Commits
rCOMMc1e55f55b290: Extract shareable logic from CreateSIWEBackupMessage component
Summary

This differential refactors CreateSIWEBackupMessage component so that most of its code and logic can be resused. It is necessary since next diff will
introduce new component that renders the same UI to already logged in SIWE users to create backup message if it is not in the database.

Test Plan
  1. Flow
  2. Test that already introduced functionality wasn't broken.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Apr 12 2024, 5:23 AM
Herald added a subscriber: ashoat. · View Herald TranscriptApr 12 2024, 5:23 AM
marcin added a parent revision: D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.Apr 12 2024, 5:23 AM
Harbormaster completed remote builds in B28186: Diff 39075.Apr 12 2024, 5:39 AM
marcin requested review of this revision.Apr 12 2024, 5:39 AM
marcin added a child revision: D11645: Force already logged in ETH users to create and sign backup message.Apr 12 2024, 5:41 AM
inka accepted this revision.Apr 12 2024, 6:54 AM
This revision is now accepted and ready to land.Apr 12 2024, 6:54 AM
ashoat added inline comments.Apr 12 2024, 8:53 AM
native/account/registration/siwe-backup-message-creation.react.js
165 ↗(On Diff #39075)

Nit: I'd reverse the order of these, to match the order in which they are defined in the file

marcin updated this revision to Diff 39126.Apr 15 2024, 8:07 AM

Memoize CreateSIWEBackupMessageBase

Harbormaster completed remote builds in B28226: Diff 39126.Apr 15 2024, 8:38 AM
marcin mentioned this in D11636: Implement screen to create backup mesage and its signature.Apr 16 2024, 5:04 AM
marcin updated this revision to Diff 39145.Apr 16 2024, 5:06 AM

Use backup icon from MaterialIcons

Harbormaster completed remote builds in B28239: Diff 39145.Apr 16 2024, 5:25 AM
marcin updated this revision to Diff 39210.Apr 18 2024, 1:22 AM

REbase to reflect changes from parent diff

Harbormaster completed remote builds in B28286: Diff 39210.Apr 18 2024, 1:40 AM
marcin updated this revision to Diff 39404.Apr 23 2024, 5:47 AM

Rebase before landing

Harbormaster completed remote builds in B28408: Diff 39404.Apr 23 2024, 6:15 AM
Closed by commit rCOMMc1e55f55b290: Extract shareable logic from CreateSIWEBackupMessage component (authored by marcin). · Explain WhyApr 23 2024, 6:54 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMc1e55f55b290: Extract shareable logic from CreateSIWEBackupMessage component.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
2 lines
156 lines

Diff 39145

View Options

native/account/registration/registration-navigator.react.js

Loading...
View Options

native/account/registration/siwe-backup-message-creation.react.js

Loading...