Page MenuHomePhabricator
Differential D11618

[native][web] Read thread activity entries from SQLite on app start
ClosedPublic
Actions

Authored by will on Apr 9 2024, 11:13 PM.
Tags
None
Referenced Files
F3399995: D11618.id39174.diff
Mon, Dec 2, 5:46 AM
F3399929: D11618.id39325.diff
Mon, Dec 2, 5:21 AM
F3399492: D11618.diff
Mon, Dec 2, 3:26 AM
Unknown Object (File)
Sat, Nov 30, 2:50 AM
Unknown Object (File)
Sat, Nov 30, 2:42 AM
Unknown Object (File)
Sat, Nov 30, 2:40 AM
Unknown Object (File)
Sat, Nov 30, 2:36 AM
Unknown Object (File)
Sat, Nov 30, 2:30 AM
View All 99 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
atul
Commits
rCOMMa11214af00e9: [native][web] Read thread activity entries from SQLite on app start
Summary

This reads thread activity entries from SQLite on app start

Depends on D11665

Test Plan

flow check.

Tested on native. On clicking through threads, verified sqlite database was updated with lastNavigatedTo values. On relaunching the app, values properly persisted. No assertion failures between redux persist and sqlite.

Tested on web. Downloaded sqlite web database and verified properly being updated on clicking through threads. Assertion not checked for web.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Apr 9 2024, 11:13 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 9 2024, 11:13 PM
will edited the summary of this revision. (Show Details)Apr 9 2024, 11:14 PM
will added a parent revision: D11617: [native][web] Start processing thread activity store with sqlite operations.
Harbormaster completed remote builds in B28121: Diff 38977.Apr 9 2024, 11:29 PM
will requested review of this revision.Apr 9 2024, 11:29 PM
atul accepted this revision.Apr 11 2024, 6:18 PM
This revision is now accepted and ready to land.Apr 11 2024, 6:18 PM
will updated this revision to Diff 39122.Apr 15 2024, 6:32 AM

entrie to entries

Harbormaster completed remote builds in B28223: Diff 39122.Apr 15 2024, 6:48 AM
will edited the summary of this revision. (Show Details)Apr 15 2024, 2:30 PM
will added a parent revision: D11665: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use sqlite.
will removed a parent revision: D11617: [native][web] Start processing thread activity store with sqlite operations.
will updated this revision to Diff 39167.Apr 16 2024, 8:59 PM

rebase

Harbormaster completed remote builds in B28256: Diff 39167.Apr 16 2024, 9:15 PM
will updated this revision to Diff 39174.Apr 16 2024, 10:19 PM

rebase

Harbormaster completed remote builds in B28259: Diff 39174.Apr 16 2024, 10:35 PM
will updated this revision to Diff 39300.Apr 19 2024, 11:27 AM

Do not assert equality of threadActivity on web

will planned changes to this revision.Apr 19 2024, 11:29 AM
will updated this revision to Diff 39301.Apr 19 2024, 11:35 AM

style. rebase before landing

This revision is now accepted and ready to land.Apr 19 2024, 11:35 AM
will edited the test plan for this revision. (Show Details)Apr 19 2024, 11:39 AM
will updated this revision to Diff 39306.Apr 19 2024, 11:42 AM
will edited the test plan for this revision. (Show Details)

rebase before landing

Harbormaster completed remote builds in B28336: Diff 39300.Apr 19 2024, 11:43 AM
Harbormaster completed remote builds in B28337: Diff 39301.Apr 19 2024, 11:51 AM
Harbormaster completed remote builds in B28340: Diff 39306.Apr 19 2024, 12:07 PM
Closed by commit rCOMMa11214af00e9: [native][web] Read thread activity entries from SQLite on app start (authored by will). · Explain WhyApr 19 2024, 1:09 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMa11214af00e9: [native][web] Read thread activity entries from SQLite on app start.

Revision Contents
Changeset List

PathSize
lib/
reducers/
1 line
45 lines
types/
2 lines
native/
data/
8 lines
web/
shared-worker/
utils/
12 lines

Diff 39325

View Options

lib/reducers/message-reducer.test.js

Loading...
View Options

lib/reducers/thread-activity-reducer.js

Loading...
View Options

lib/types/store-ops-types.js

Loading...
View Options

native/data/sqlite-data-handler.js

Loading...
View Options

web/shared-worker/utils/store.js

Loading...