Page MenuHomePhabricator
Differential D11716

Enable backup creation and upload for SIWE users from JS
ClosedPublic
Actions

Authored by marcin on Apr 22 2024, 11:29 AM.
Tags
None
Referenced Files
F3406035: D11716.diff
Wed, Dec 4, 12:20 AM
Unknown Object (File)
Nov 3 2024, 6:30 AM
Unknown Object (File)
Oct 17 2024, 7:11 PM
Unknown Object (File)
Oct 16 2024, 11:17 PM
Unknown Object (File)
Oct 16 2024, 10:02 PM
Unknown Object (File)
Oct 12 2024, 10:47 PM
Unknown Object (File)
Oct 12 2024, 6:36 PM
Unknown Object (File)
Oct 12 2024, 6:36 PM
View All 87 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
bartek
Commits
rCOMMbfc1f2c9c4ba: Enable backup creation and upload for SIWE users from JS
Summary

This differential enalbes backup upload for SIWE users.

Test Plan
  1. Log in as SIWE user.
  2. Tap upload backup button.
  3. Ensure it succeeds and that there is an entry with full backup message in the dynamodb.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-5267
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Apr 22 2024, 11:29 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 22 2024, 11:29 AM
marcin added a parent revision: D11715: Update native backup code to handle siwe backup message.Apr 22 2024, 11:30 AM
marcin updated this revision to Diff 39357.Apr 22 2024, 11:40 AM

Fix double space in error text

Harbormaster failed remote builds in B28365: Diff 39355!Apr 22 2024, 11:42 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 22 2024, 12:03 PM
Harbormaster failed remote builds in B28367: Diff 39357!
marcin updated this revision to Diff 39389.Apr 23 2024, 3:46 AM

Fix commtest

marcin added a child revision: D11733: Update latest backup id search index to include 'msgBackup'.Apr 23 2024, 3:49 AM
Harbormaster completed remote builds in B28394: Diff 39389.Apr 23 2024, 4:05 AM
marcin requested review of this revision.Apr 23 2024, 4:05 AM
kamil accepted this revision.Apr 26 2024, 12:40 AM
This revision is now accepted and ready to land.Apr 26 2024, 12:40 AM
marcin updated this revision to Diff 39539.Apr 26 2024, 6:23 AM

Rebase

Harbormaster completed remote builds in B28504: Diff 39539.Apr 26 2024, 6:46 AM
marcin updated this revision to Diff 40001.May 9 2024, 6:20 AM

Rebase before landing

Harbormaster completed remote builds in B28800: Diff 40001.May 9 2024, 6:39 AM
Closed by commit rCOMMbfc1f2c9c4ba: Enable backup creation and upload for SIWE users from JS (authored by marcin). · Explain WhyMay 9 2024, 7:00 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMbfc1f2c9c4ba: Enable backup creation and upload for SIWE users from JS.
ashoat added inline comments.May 9 2024, 3:50 PM
native/backup/backup-handler.js
26 ↗(On Diff #40011)

Nice!!

tomek mentioned this in D12050: [lib] Create a compaction after schema-changing migration.May 16 2024, 1:02 AM

Revision Contents
Changeset List

PathSize
native/
backup/
14 lines
28 lines
profile/
4 lines

Diff 39357

View Options

native/backup/backup-handler.js

Loading...
View Options

native/backup/use-client-backup.js

Loading...
View Options

native/profile/profile-screen.react.js

Loading...