This differential modifies SIWE component so that it renders different user texts based on the type of message we want to sign.
Details
Details
It may sound a little strange:
- Modify fullscreen-siwe-panel.react.js/connect-ethereum.react.js to provide SIWEMEssageTypes.MSG_BACKUP instead of MSG_AUTH.
- Attempt/log in registration process.
- Ensure that log in/registration is succesfull but the texts that are displayed refer to backup message generation.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| landing/siwe.react.js | ||
|---|---|---|
| 128–134 ↗ | (On Diff #39060) | This is relevant both for backup flow and auth flow, right? Just want not make sure this early return won't break anything for auth |
| 135–140 ↗ | (On Diff #39060) | Guessing backup flow also requires nonce since it's still a SIWE message(?), so this won't break anything |
Comment Actions
Would be good to include screenshots of what the various screens look like from mobile. (You can omit the original screen if it's unchanged.)
| landing/siwe.react.js | ||
|---|---|---|
| 128–134 ↗ | (On Diff #39060) | Yes - as we introduced type for both backup and auth the auth flow also needs to provide this parameter. I added it explicitly in each place that performs SIWE auth. |
| 135–140 ↗ | (On Diff #39060) | Yes - the only thing in which backup and auth differ are user texts. The rest of the flow - including message format - are the same. |