Details
flow + close reading.
Will test generally at end to make sure things work as expected. Don't think it's practical to manually test each of these trivial changes.
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/modals/threads/settings/thread-settings-general-tab.react.js | ||
|---|---|---|
| 83–86 | Nit: usually we're calling hooks without altering the returned value inline - the current approach makes it less obvious that this is a hook and not a plain function. (doesn't matter too much, though). | |
| web/modals/threads/settings/thread-settings-modal.react.js | ||
| 100–119 | It looks like it could be more convenient to have a hook that returns a set with all the permissions. But I don't think it is worth changing at this point. | |
| 124 | We're changing the logic here - instead of checking the permissions of the thread from the parameter, we're checking the one from the selector. Is it safe? If it is safe, do we still need thread parameter in this callback? | |
| web/modals/threads/settings/thread-settings-modal.react.js | ||
|---|---|---|
| 149 ↗ | (On Diff #40789) | Ah yeah thanks for catching that, will update diff to remove. |