Page MenuHomePhabricator
Differential D11754

[native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`
ClosedPublic
Actions

Authored by atul on Apr 23 2024, 2:31 PM.
Tags
None
Referenced Files
F3375035: D11754.diff
Tue, Nov 26, 5:57 PM
Unknown Object (File)
Thu, Nov 7, 1:34 PM
Unknown Object (File)
Sun, Nov 3, 3:04 AM
Unknown Object (File)
Tue, Oct 29, 7:21 AM
Unknown Object (File)
Oct 25 2024, 3:16 PM
Unknown Object (File)
Oct 12 2024, 4:53 PM
Unknown Object (File)
Oct 12 2024, 4:53 PM
Unknown Object (File)
Oct 12 2024, 4:53 PM
View All 54 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
varun
will
Commits
rCOMM5c7f9868ce1a: [native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Summary

Similar to D11753, but for ThreadSettings

Depends on D11753

Test Plan

flow + close reading.

Will test generally at end to make sure things work as expected. Don't think it's practical to manually test each of these trivial changes.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 23 2024, 2:31 PM
Herald added a subscriber: ashoat. · View Herald TranscriptApr 23 2024, 2:31 PM
Harbormaster completed remote builds in B28426: Diff 39431.Apr 23 2024, 3:14 PM
atul requested review of this revision.Apr 23 2024, 3:14 PM
tomek accepted this revision.Apr 24 2024, 4:53 AM

Will test generally at end to make sure things work as expected.

Is this something that will be done later in the stack?

This revision is now accepted and ready to land.Apr 24 2024, 4:53 AM
atul added a comment.Apr 25 2024, 10:13 AM
In D11754#337417, @tomek wrote:

Will test generally at end to make sure things work as expected.

Is this something that will be done later in the stack?

Yeah and have been doing basic sanity checks throughout with log statements

atul added a child revision: D11786: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ViewInviteLinksScreen`.Apr 25 2024, 1:54 PM
atul updated this revision to Diff 39561.Apr 26 2024, 10:55 AM

land

Harbormaster completed remote builds in B28516: Diff 39561.Apr 26 2024, 11:14 AM
Closed by commit rCOMM5c7f9868ce1a: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul). · Explain WhyApr 26 2024, 11:46 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM5c7f9868ce1a: [native] Replace `threadHasPermission` with `useThreadHasPermission` in….

Revision Contents
Changeset List

PathSize
native/
chat/
settings/
16 lines

Diff 39431

View Options

native/chat/settings/thread-settings-description.react.js

Loading...