Page MenuHomePhabricator
Differential D11752

[web] Replace `threadHasPermission` with `useThreadHasPermission` in `MembersModal`
ClosedPublic
Actions

Authored by atul on Apr 23 2024, 1:37 PM.
Tags
None
Referenced Files
F6241284: D11752.diff
Fri, Apr 25, 12:36 AM
Unknown Object (File)
Sat, Apr 19, 9:04 AM
Unknown Object (File)
Sat, Apr 19, 5:19 AM
Unknown Object (File)
Fri, Apr 18, 3:04 PM
Unknown Object (File)
Fri, Apr 18, 6:52 AM
Unknown Object (File)
Fri, Apr 18, 5:30 AM
Unknown Object (File)
Thu, Apr 17, 8:29 PM
Unknown Object (File)
Mar 11 2025, 4:56 AM
View All Files
Subscribers
ashoat

Details

Reviewers
varun
ginsu
tomek
will
Commits
rCOMMb6c3358bdf37: [web] Replace `threadHasPermission` with `useThreadHasPermission` in…
Summary

Similar to D11751, but for MembersModal.

Depends on D11751

Test Plan

flow + close reading.

Will test generally at end to make sure things work as expected. Don't think it's practical to manually test each of these trivial changes.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
members/
4 lines

Diff 39466

View Options

web/modals/threads/members/members-modal.react.js

// @flow // @flow
import t, { type TInterface, type TUnion } from 'tcomb'; import t, { type TInterface, type TUnion } from 'tcomb';
import { import {
tHexEncodedPermissionsBitmask, tHexEncodedPermissionsBitmask,
tHexEncodedRolePermission, tHexEncodedRolePermission,
} from './minimally-encoded-thread-permissions.js'; } from './minimally-encoded-thread-permissions.js';
import { specialRoleValidator } from './special-roles.js'; import { specialRoleValidator } from './special-roles.js';
import type { import type {
MemberInfo, MemberInfoWithPermissions,
ThreadCurrentUserInfo, ThreadCurrentUserInfo,
RawThreadInfo, RawThreadInfo,
RoleInfo, RoleInfo,
RoleInfoWithoutSpecialRole, RoleInfoWithoutSpecialRole,
RawThreadInfoWithoutSpecialRole, RawThreadInfoWithoutSpecialRole,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import { import {
type LegacyRawThreadInfo, type LegacyRawThreadInfo,
Show All 37 Lines tShape<RoleInfoPossiblyWithIsDefaultField>({
id: tID, id: tID,
name: t.String, name: t.String,
minimallyEncoded: tBool(true), minimallyEncoded: tBool(true),
permissions: t.list(tHexEncodedRolePermission), permissions: t.list(tHexEncodedRolePermission),
specialRole: t.maybe(specialRoleValidator), specialRole: t.maybe(specialRoleValidator),
isDefault: t.maybe(t.Boolean), isDefault: t.maybe(t.Boolean),
}); });
const memberInfoValidator: TInterface<MemberInfo> = tShape<MemberInfo>({ const memberInfoWithPermissionsValidator: TInterface<MemberInfoWithPermissions> =
tShape<MemberInfoWithPermissions>({
...legacyMemberInfoValidator.meta.props, ...legacyMemberInfoValidator.meta.props,
minimallyEncoded: tBool(true), minimallyEncoded: tBool(true),
permissions: tHexEncodedPermissionsBitmask, permissions: tHexEncodedPermissionsBitmask,
}); });
const rawThreadInfoValidator: TInterface<RawThreadInfo> = tShape<RawThreadInfo>( const rawThreadInfoValidator: TInterface<RawThreadInfo> = tShape<RawThreadInfo>(
{ {
...legacyRawThreadInfoValidator.meta.props, ...legacyRawThreadInfoValidator.meta.props,
minimallyEncoded: tBool(true), minimallyEncoded: tBool(true),
members: t.list(memberInfoValidator), members: t.list(memberInfoWithPermissionsValidator),
roles: t.dict(tID, roleInfoValidator), roles: t.dict(tID, roleInfoValidator),
currentUser: threadCurrentUserInfoValidator, currentUser: threadCurrentUserInfoValidator,
}, },
); );
const roleInfoWithoutSpecialRolesValidator: TInterface<RoleInfoWithoutSpecialRole> = const roleInfoWithoutSpecialRolesValidator: TInterface<RoleInfoWithoutSpecialRole> =
tShape<RoleInfoWithoutSpecialRole>({ tShape<RoleInfoWithoutSpecialRole>({
...roleInfoValidatorBase, ...roleInfoValidatorBase,
Show All 10 Linesconst mixedRawThreadInfoValidator: TUnion<
LegacyRawThreadInfo | RawThreadInfo | RawThreadInfoWithoutSpecialRole, LegacyRawThreadInfo | RawThreadInfo | RawThreadInfoWithoutSpecialRole,
> = t.union([ > = t.union([
legacyRawThreadInfoValidator, legacyRawThreadInfoValidator,
rawThreadInfoValidator, rawThreadInfoValidator,
rawThreadInfoWithoutSpecialRoles, rawThreadInfoWithoutSpecialRoles,
]); ]);
export { export {
memberInfoValidator, memberInfoWithPermissionsValidator,
roleInfoValidator, roleInfoValidator,
persistedRoleInfoValidator, persistedRoleInfoValidator,
threadCurrentUserInfoValidator, threadCurrentUserInfoValidator,
rawThreadInfoValidator, rawThreadInfoValidator,
mixedRawThreadInfoValidator, mixedRawThreadInfoValidator,
}; };